Bug 125666

Summary: CStack Branch: Put all stack saving and restoring callToJavaScript in {push/pop}CalleeSaves
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: mark.lam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

Michael Saboff
Reported 2013-12-12 16:21:50 PST
The LLInt stub callToJavaScript uses the peudo-ops pushCalleeSaves and popCalleeSaves to save and restore C calling convention calle saves. It also uses a separate value to leave extra stack space. This was needed for aligning the stack and space for outgoing calls to C helper function. The aligning should be done in {push,pop}CalleeSaves and the extra space is now at the top of the stack and will be handled separately.
Attachments
Patch (3.73 KB, patch)
2013-12-12 16:27 PST, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-12-12 16:27:27 PST
Created attachment 219134 [details] Patch
Michael Saboff
Comment 2 2013-12-12 16:27:52 PST
Landed in r160516 on the jsCStack branch: <http://trac.webkit.org/160516 >
Geoffrey Garen
Comment 3 2013-12-12 16:30:00 PST
Comment on attachment 219134 [details] Patch r=me
Mark Lam
Comment 4 2014-01-13 18:44:48 PST
Review status updated in r161938: <http://trac.webkit.org/r161938>.
Note You need to log in before you can comment on or make changes to this bug.