Bug 125626

Summary: Delete RVCT related code parts.
Product: WebKit Reporter: ezisfake <Szanka.Peter>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, galpeter, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
darin: review+, commit-queue: commit-queue-
fixed changelog file none

ezisfake
Reported 2013-12-12 03:17:39 PST
Delete RVCT related code parts.
Attachments
patch (11.00 KB, patch)
2013-12-13 03:04 PST, ezisfake 		no flags
DetailsFormatted DiffDiff
patch (13.00 KB, patch)
2013-12-13 04:59 PST, ezisfake 		darin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
fixed changelog file (10.88 KB, patch)
2013-12-16 05:36 PST, ezisfake 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
ezisfake
Comment 1 2013-12-13 03:04:05 PST
Created attachment 219165 [details] patch Comes after this: https://bugs.webkit.org/show_bug.cgi?id=125625
ezisfake
Comment 2 2013-12-13 04:59:33 PST
Created attachment 219168 [details] patch fixed
WebKit Commit Bot
Comment 3 2013-12-13 10:56:34 PST
Comment on attachment 219168 [details] patch Rejecting attachment 219168 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 219168, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/48608184
ezisfake
Comment 4 2013-12-16 05:36:37 PST
Created attachment 219307 [details] fixed changelog file
WebKit Commit Bot
Comment 5 2013-12-16 10:07:46 PST
Comment on attachment 219307 [details] fixed changelog file Clearing flags on attachment: 219307 Committed r160648: <http://trac.webkit.org/changeset/160648>
WebKit Commit Bot
Comment 6 2013-12-16 10:07:48 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2013-12-16 10:28:40 PST
Comment on attachment 219307 [details] fixed changelog file View in context: https://bugs.webkit.org/attachment.cgi?id=219307&action=review > Source/WTF/wtf/Compiler.h:116 > /* --gnu option of the RVCT compiler also defines __GNUC__ */ Probably should go back and remove this comment too.
Csaba Osztrogonác
Comment 8 2013-12-19 08:19:13 PST
(In reply to comment #7) > (From update of attachment 219307 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219307&action=review > > > Source/WTF/wtf/Compiler.h:116 > > /* --gnu option of the RVCT compiler also defines __GNUC__ */ > > Probably should go back and remove this comment too. fix landed in http://trac.webkit.org/changeset/160832
Note You need to log in before you can comment on or make changes to this bug.