Bug 125559

Summary:

Move JavaScriptCore off the legacy WebKit availability macros

Product:

WebKit

Reporter:

Mark Rowe (bdash) <mrowe>

Component:

JavaScriptCore

Assignee:

Mark Rowe (bdash) <mrowe>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Mark Rowe (bdash) 2013-12-11 01:39:33 PST

The legacy WebKit availability macros are verbose, confusing, and provide no benefit over using the system availability macros directly. The original vision was that they'd serve a cross-platform purpose but that never came to be.

Comment 1 Mark Rowe (bdash) 2013-12-11 01:41:29 PST

Created attachment 218940 [details]
Patch

Comment 2 WebKit Commit Bot 2013-12-11 01:43:47 PST

Attachment 218940 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBasePrivate.h', u'Source/JavaScriptCore/API/JSContextRef.h', u'Source/JavaScriptCore/API/JSContextRefPrivate.h', u'Source/JavaScriptCore/API/JSObjectRef.h', u'Source/JavaScriptCore/API/JSValueRef.h', u'Source/JavaScriptCore/ChangeLog', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/API/JSValueRef.h:221:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSValueRef.h:232:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSBasePrivate.h:46:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSContextRef.h:59:  The parameter name "group" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSContextRef.h:66:  The parameter name "group" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSContextRef.h:95:  The parameter name "group" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 WebKit Commit Bot 2013-12-11 14:03:07 PST

Comment on attachment 218940 [details]
Patch

Clearing flags on attachment: 218940

Committed r160452: <http://trac.webkit.org/changeset/160452>

Comment 4 WebKit Commit Bot 2013-12-11 14:03:10 PST

All reviewed patches have been landed.  Closing bug.