Bug 125554
Summary: | Simple getter access performance has regressed by 1.5x since release safari | ||
---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> |
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> |
Status: | NEW | ||
Severity: | Normal | CC: | fpizlo, ggaren, msaboff, oliver, saam, webkit-bug-importer, zan |
Priority: | P2 | Keywords: | InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Oliver Hunt
So this simple benchmark:
var j = 1;
var o = {get foo() { return j+=0.31; } }
var start = new Date;
var result = 0;
for (var i = 0; i < 10000000; i++)
result += o.foo
var end = new Date;
print("Took: " + (end -start) + "ms. Result -> " + result);
Is now 1.5x slower on trunk than in released safari.
I wonder if this is due to calling convention changes, so i've cc'd michael.
Haven't had time to analyse at all as i came across this while working on caching prototype accessor lookups
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
<rdar://problem/28227246>
Saam Barati
I wonder if this is still the case. I suspect we're actually much faster today for this benchmark than we used to be.
Saam Barati
I'll run some tests over the weekend when I have time to rollback to an old webkit.