Bug 125535

Summary: Reduce the mass templatizing of the JS parser
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gyuyoung.kim, rego+ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch msaboff: review+

Oliver Hunt
Reported 2013-12-10 12:46:21 PST
Reduce the mass templatizing of the JS parser
Attachments
Patch (31.84 KB, patch)
2013-12-10 12:49 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (32.48 KB, patch)
2013-12-10 13:02 PST, Oliver Hunt 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-12-10 12:49:18 PST
Created attachment 218895 [details] Patch
EFL EWS Bot
Comment 2 2013-12-10 12:53:20 PST
Comment on attachment 218895 [details] Patch Attachment 218895 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/46278343
Oliver Hunt
Comment 3 2013-12-10 13:02:38 PST
Created attachment 218898 [details] Patch
Sam Weinig
Comment 4 2013-12-10 13:04:10 PST
Comment on attachment 218895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218895&action=review > Source/JavaScriptCore/ChangeLog:11 > + sites. This reduces the code size by around 15%. Code size of what? All of WebKit in Release? Just the parser?
Oliver Hunt
Comment 5 2013-12-10 13:05:19 PST
just the parser. fixed change log.
Michael Saboff
Comment 6 2013-12-10 13:14:58 PST
Comment on attachment 218898 [details] Patch r=me
Oliver Hunt
Comment 7 2013-12-10 13:16:43 PST
Committed r160383: <http://trac.webkit.org/changeset/160383>
Note You need to log in before you can comment on or make changes to this bug.