Bug 125474

Summary:

[MSE] VideoPlaybackQuality should not be a NoInterfaceObject

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

DOM

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ahmad.saleem792, ap, bfulgham, buildbot, cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, kondapallykalyan, rniwa, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

125380

Bug Blocks:

Attachments:

Description	Flags
Follow up patch	none
Patch	sam: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Patch for landing	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none

Jer Noble

Reported 2013-12-09 16:34:34 PST

[MSE] VideoPlaybackQuality should not be a NoInterfaceObject

Attachments
Follow up patch (1.30 KB, patch) 2013-12-09 16:37 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (5.14 KB, patch) 2013-12-09 17:20 PST, Jer Noble	sam: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (525.58 KB, application/zip) 2013-12-09 18:58 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (492.31 KB, application/zip) 2013-12-09 19:30 PST, Build Bot	no flags	Details
Patch for landing (6.71 KB, patch) 2013-12-09 19:46 PST, Jer Noble	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (534.00 KB, application/zip) 2013-12-09 20:23 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (528.20 KB, application/zip) 2013-12-09 21:40 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (491.05 KB, application/zip) 2013-12-09 21:57 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (529.33 KB, application/zip) 2013-12-09 22:42 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (494.44 KB, application/zip) 2013-12-09 22:57 PST, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2013-12-09 16:37:24 PST

Created attachment 218811 [details] Follow up patch

Sam Weinig

Comment 2 2013-12-09 16:44:21 PST

Comment on attachment 218811 [details] Follow up patch You should probably add a test.

Jer Noble

Comment 3 2013-12-09 17:20:05 PST

Created attachment 218815 [details] Patch

Build Bot

Comment 4 2013-12-09 18:58:38 PST

Comment on attachment 218815 [details] Patch Attachment 218815 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/47338060 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 5 2013-12-09 18:58:40 PST

Created attachment 218820 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2013-12-09 19:30:18 PST

Comment on attachment 218815 [details] Patch Attachment 218815 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/47258241 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 7 2013-12-09 19:30:21 PST

Created attachment 218822 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Jer Noble

Comment 8 2013-12-09 19:46:14 PST

Created attachment 218824 [details] Patch for landing

Build Bot

Comment 9 2013-12-09 20:23:37 PST

Comment on attachment 218815 [details] Patch Attachment 218815 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/47288250 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 10 2013-12-09 20:23:40 PST

Created attachment 218825 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 11 2013-12-09 21:40:48 PST

Comment on attachment 218824 [details] Patch for landing Attachment 218824 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/47428006 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 12 2013-12-09 21:40:50 PST

Created attachment 218831 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 13 2013-12-09 21:57:24 PST

Comment on attachment 218824 [details] Patch for landing Attachment 218824 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/46598015 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 14 2013-12-09 21:57:28 PST

Created attachment 218833 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 15 2013-12-09 22:42:18 PST

Comment on attachment 218824 [details] Patch for landing Attachment 218824 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/46508034 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 16 2013-12-09 22:42:21 PST

Created attachment 218835 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 17 2013-12-09 22:57:05 PST

Comment on attachment 218824 [details] Patch for landing Attachment 218824 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/46278325 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 18 2013-12-09 22:57:08 PST

Created attachment 218836 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Ahmad Saleem

Comment 19 2022-09-10 16:39:25 PDT

I searched with Bug ID on Webkit GitHub and it has not landed and it was trying to modify IDL file here: https://github.com/WebKit/WebKit/blob/8afe31a018b11741abdf9b4d5bb973d7c1d9ff05/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.idl#L30 I think this FIXME might be what this bug was trying to fix: // FIXME: This is not specified as "LegacyNoInterfaceObject". It should have an interface object. Is it something still needed? Further, this IDL file of Chromium / Blink - third_party/blink/renderer/modules/mediasource/video_playback_quality.idl I don't see "NoInterfaceObject". I will leave to someone else to comment on what is needed from this bug. Thanks!

Ahmad Saleem

Comment 20 2022-09-10 16:40:54 PDT

(In reply to Ahmad Saleem from comment #19) > I searched with Bug ID on Webkit GitHub and it has not landed and it was > trying to modify IDL file here: > > https://github.com/WebKit/WebKit/blob/ > 8afe31a018b11741abdf9b4d5bb973d7c1d9ff05/Source/WebCore/Modules/mediasource/ > VideoPlaybackQuality.idl#L30 > > I think this FIXME might be what this bug was trying to fix: > > // FIXME: This is not specified as "LegacyNoInterfaceObject". It should have > an interface object. > > Is it something still needed? > > Further, this IDL file of Chromium / Blink - > third_party/blink/renderer/modules/mediasource/video_playback_quality.idl > I don't see "NoInterfaceObject". > > I will leave to someone else to comment on what is needed from this bug. > Thanks! Blink - https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/mediasource/video_playback_quality.idl?q=Video_Playback_Quality.idl

Alexey Proskuryakov

Comment 21 2022-09-11 13:45:09 PDT

window.VideoPlaybackQuality is undefined in Safaris, but a function in Firefox and Chrome. So this is still a bug.

Ahmad Saleem

Comment 22 2022-09-12 02:13:42 PDT

We are failing WPT tests as well: https://wpt.fyi/results/media-playback-quality/idlharness.window.html?label=master&label=experimental&aligned&view=subtest&q=playback%20quality

Radar WebKit Bug Importer

Comment 23 2022-09-12 10:00:03 PDT

<rdar://problem/99826631>

EWS

Comment 24 2023-10-28 12:48:49 PDT

Committed 269893@main (b5ffcfbc6d16): <https://commits.webkit.org/269893@main> Reviewed commits have been landed. Closing PR #19678 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.