Bug 125464

Summary: GL_HALF_FLOAT_ARB not defined
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Minor CC: bfulgham, commit-queue, dino, kondapallykalyan, noam, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2013-12-09 12:01:20 PST
I'm not sure where GL_HALF_FLOAT_ARB is defined, but http://trac.webkit.org/changeset/160119 broke WebGL on Windows. Is putting PLATFORM(MAC) around it the right thing to do? Maybe #if !USE(OPENGL_ES_2), or maybe I should just find the definition and include it.
Attachments
Patch (1.44 KB, patch)
2013-12-09 12:06 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (1.51 KB, patch)
2013-12-09 12:12 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-12-09 12:06:01 PST
Created attachment 218786 [details] Patch
Darin Adler
Comment 2 2013-12-09 12:11:03 PST
Comment on attachment 218786 [details] Patch Is this a better fix than the one in bug 125383?
Alex Christensen
Comment 3 2013-12-09 12:12:36 PST
Created attachment 218787 [details] Patch
Alex Christensen
Comment 4 2013-12-09 12:15:56 PST
I'm not sure what would happen if you gave glTexSubImage2D a value it didn't recognize. I'm not sure what happens when you give the GLES implementation of glTexSubImage2D 0x140B as the type, or if this problem will ever come up, or why this change was added in the first place.
Alex Christensen
Comment 5 2013-12-09 12:16:44 PST
*** This bug has been marked as a duplicate of bug 125383 ***
Note You need to log in before you can comment on or make changes to this bug.