Bug 125448

Summary: Merge mark_for_landing and mark_for_commit_queue into one argument
Product: WebKit Reporter: Dániel Bátyai <dbatyai.u-szeged>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Proposed patch none

Dániel Bátyai
Reported 2013-12-09 06:09:45 PST
In common/net/bugzilla/bugzilla.py # FIXME: mark_for_commit_queue and mark_for_landing should be joined into a single commit_flag argument. # FIXME: Use enum instead of two booleans Since mark_for_landing implies mark_for_commit_queue, these two can be merged into one enum argument.
Attachments
Proposed patch (10.79 KB, patch)
2013-12-09 06:15 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Proposed patch (10.64 KB, patch)
2013-12-10 01:23 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dániel Bátyai
Comment 1 2013-12-09 06:15:39 PST
Created attachment 218754 [details] Proposed patch
Ryosuke Niwa
Comment 2 2013-12-09 10:29:43 PST
Comment on attachment 218754 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=218754&action=review > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:568 > Why don't we add else and return '+' there instead? > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:-567 > - if mark_for_commit_queue: And replace this with != mark_for_nothing.
Dániel Bátyai
Comment 3 2013-12-10 01:23:02 PST
Created attachment 218841 [details] Proposed patch
WebKit Commit Bot
Comment 4 2013-12-10 02:15:28 PST
Comment on attachment 218841 [details] Proposed patch Clearing flags on attachment: 218841 Committed r160353: <http://trac.webkit.org/changeset/160353>
WebKit Commit Bot
Comment 5 2013-12-10 02:15:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.