Bug 125414

Summary: int() cast in ParseContext.cpp causes signed / unsigned comparison warning
Product: WebKit Reporter: Brendan Long <b.long>
Component: New BugsAssignee: Brendan Long <b.long>
Status: RESOLVED INVALID    
Severity: Normal CC: bfulgham, commit-queue, dino, kondapallykalyan, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brendan Long
Reported 2013-12-08 07:27:41 PST
int() cast in ParseContext.cpp causes signed / unsigned comparison warning
Attachments
Patch (1.59 KB, patch)
2013-12-08 08:15 PST, Brendan Long 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brendan Long
Comment 1 2013-12-08 08:14:12 PST
Patch submitted upstream: https://code.google.com/p/angleproject/issues/detail?id=536
Brendan Long
Comment 2 2013-12-08 08:15:04 PST
Created attachment 218691 [details] Patch
WebKit Commit Bot
Comment 3 2013-12-08 08:16:03 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
WebKit Commit Bot
Comment 4 2013-12-08 08:16:10 PST
Attachment 218691 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/src/compiler/ParseContext.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/ThirdParty/ANGLE/src/compiler/ParseContext.cpp:538: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brendan Long
Comment 5 2014-01-14 15:29:04 PST
This was fixed upstream and will be fixed in WebKit as soon as someone updates ANGLE.
Note You need to log in before you can comment on or make changes to this bug.