Bug 125398
| Summary: | Don't recalc all styles when adding @keyframes, @import and @page | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | barraclough, benjamin, kling, koivisto, psolanki, simon.fraser, syoichi |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/bd8fbc63697a3ac187ee70e7a39ae1c5e039062c
This applies to @import and @page rules as well.
There are probably other rule types which we could
be smarter about, but @keyframes is most common.
I wish I had a good way to test this. I considered
writing an inspector-timeline test, or adding a
"style recalc count" to settings.internals. I think
long-term we should consider exposing recalc information
as part of window.performance? But for now there
doesn't seem to be a nice way to test this change.
Elliott and I discovered when writing/reviewing this
that adding @keyframes after an animation is first
created has no effect in WebKit/Blink. It should!
I've filed: http://crbug.com/307760
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |