Bug 125345

Summary: Define SHA1 hash size in SHA1.h and use it at various places.
Product: WebKit Reporter: Laszlo Vidacs <lvidacs.u-szeged>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, lvidacs.u-szeged, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Laszlo Vidacs
Reported 2013-12-06 06:32:05 PST
SHA1 size is used at various places but usually defined as a local variable. A common constant in SHA1.h used by all parties would be a better solution.
Attachments
Patch (5.69 KB, patch)
2013-12-06 06:45 PST, Laszlo Vidacs 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Vidacs
Comment 1 2013-12-06 06:45:34 PST
Created attachment 218593 [details] Patch
Anders Carlsson
Comment 2 2013-12-06 08:49:21 PST
Comment on attachment 218593 [details] Patch I like this change, but could you also make computeHash take an std::array<uint8_t, hashSize>. There's no need for it to take a Vector.
WebKit Commit Bot
Comment 3 2013-12-06 10:51:40 PST
Comment on attachment 218593 [details] Patch Clearing flags on attachment: 218593 Committed r160228: <http://trac.webkit.org/changeset/160228>
WebKit Commit Bot
Comment 4 2013-12-06 10:56:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.