Summary: | JSC: Simplify interface between throw and catch handler | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, eflews.bot, fpizlo, ggaren, gyuyoung.kim, rniwa | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Michael Saboff
2013-12-05 18:58:56 PST
Created attachment 218562 [details]
Patch
Comment on attachment 218562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218562&action=review r=me > Source/JavaScriptCore/jit/CCallHelpers.h:1578 > move(TrustedImmPtr(vm()), GPRInfo::regT0); > loadPtr(Address(GPRInfo::regT0, VM::targetMachinePCForThrowOffset()), GPRInfo::regT1); This should just be a load of an absolute address (VM::targetMachinePCForThrow). No need to put VM in a register. Comment on attachment 218562 [details] Patch Attachment 218562 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/44958010 Comment on attachment 218562 [details] Patch Attachment 218562 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/45198001 New failing tests: js/dom/JSON-parse.html Created attachment 218569 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Committed r160213: <http://trac.webkit.org/changeset/160213> (In reply to comment #5) > Created an attachment (id=218569) [details] > Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 > > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. > Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5 Didn't see this crash before landing. Looks like the current callFrame in the catch block doesn't have a codeBlock. Investigating further. Working in a fix. (In reply to comment #8) > Working in a fix. Fix tracked with https://bugs.webkit.org/show_bug.cgi?id=125335 - REGRESSION(r160213): Crash in js/dom/JSON-parse.html |