Bug 125326 – [Coordinated Graphics] '-webkit-mask-image: -webkit-gradient' doesn't work for AC layer.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Jeong Jin Gyeong]

Test:
  http://black.company100.com/test/mask-image/


Google Chrome 27, GTK r160203 MiniBrowser display a green box correctly, but EFL r160203 MiniBrowser displays a red box.

[Yonggeol Jung]

Created attachment 236439 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 236439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236439&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:810
> +        toCoordinatedGraphicsLayer(maskLayer())->syncPendingStateChangesIncludingSubLayers();

Please add test case for this fix.

[Yonggeol Jung]

Created attachment 236513 [details]
Patch

[Yonggeol Jung]

Created attachment 236514 [details]
Patch

[Yonggeol Jung]

Created attachment 236515 [details]
Patch

[Yonggeol Jung]

Created attachment 236516 [details]
Patch

[Yonggeol Jung]

(In reply to comment #2)
> (From update of attachment 236439 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236439&action=review
> 
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:810
> > +        toCoordinatedGraphicsLayer(maskLayer())->syncPendingStateChangesIncludingSubLayers();
> 
> Please add test case for this fix.

Related test case already exists.
(compositing/masks/mask-of-clipped-layer.html)
But, currently layout tests in compositing directory are marked as "skip" on EFL Port.

[Yonggeol Jung]

(In reply to comment #7)
> (In reply to comment #2)
> > (From update of attachment 236439 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=236439&action=review
> > 
> > > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:810
> > > +        toCoordinatedGraphicsLayer(maskLayer())->syncPendingStateChangesIncludingSubLayers();
> > 
> > Please add test case for this fix.
> 
> Related test case already exists.
> (compositing/masks/mask-of-clipped-layer.html)
> But, currently layout tests in compositing directory are marked as "skip" on EFL Port.

I'll check more.

[Yonggeol Jung]

Created attachment 236520 [details]
Patch

[Yonggeol Jung]

Created attachment 236521 [details]
Patch

[Yonggeol Jung]

Created attachment 236523 [details]
Patch

[Yonggeol Jung]

Created attachment 236524 [details]
Patch

[Yonggeol Jung]

Created attachment 240113 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 240113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240113&action=review

Currently EFL WebKitTestRunner doesn't enable AC as well as pixel test. So, I think this patch only can be verified locally.

> Source/WebCore/ChangeLog:15
> +

Could you add below line to here ?

Test : compositing/masks/mask-of-clipped-layer.html

[Yonggeol Jung]

Created attachment 240174 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 240174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240174&action=review

> Source/WebCore/ChangeLog:13
> +        If layout test runs as AC mode, this test case will pass on EFL port.

Please add a new line here.

> Source/WebCore/ChangeLog:14
> +        Test : compositing/masks/mask-of-clipped-layer.html

Do not add a space in "Test :"

Just "Test:"

[Yonggeol Jung]

Created attachment 240178 [details]
Patch

[Yonggeol Jung]

Created attachment 240182 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 240182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240182&action=review

> Source/WebCore/ChangeLog:8
> +        Mask layer did not request to sync, so it wasn't shown.

YongGeol, I improve to clear this description a little.

"Mask layer hasn't requested to synchronize with AC layer in CoordinatedGraphics so far. That's why the mask layer isn't shown under CoordinatedGraphics.
Thus this patch lets the mask layer synchronize with the AC layer whenever AC layer is updated.

Below layout test case is related to this issue when --pixel test is enabled. Unfortunately EFL WebKitTestRunner doesn't support AC mode yet.
When EFL test framework supports AC mode, the test will be passed."

[Yonggeol Jung]

Created attachment 240184 [details]
Patch

[Yonggeol Jung]

Thanks for your detailed comments. :)

[Yonggeol Jung]

Created attachment 240186 [details]
Patch

[Yonggeol Jung]

Created attachment 240187 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 240187 [details]
Patch

As mentioned in ChangeLog, this fix can't be tested by EWebKit2 test framework yet. As talked with YongGeol locally, this fix was tested by Tizen product which enables AC mode. When AC will be supported by EWebKit trunk, this fix will be tested as well. rs=me.

[WebKit Commit Bot]

Comment on attachment 240187 [details]
Patch

Clearing flags on attachment: 240187

Committed r174924: <http://trac.webkit.org/changeset/174924>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.