Bug 125324

Summary:

Web Inspector: Push More Inspector Required Classes Down into JavaScriptCore

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, dbates, eflews.bot, esprehn+autocc, ggaren, graouts, gtk-ews, gyuyoung.kim, joepeck, ltilve+ews, mkwst, rakuco, rniwa, sam, timothy, webkit-bug-importer, xan.lopez

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] PART 1: InspectAgentBase, InspectorAgentRegistry, InspectorBackendDispatcher, InspectorValues	none
[PATCH] PART 2: ScriptObject, ScriptValue	timothy: review+
[PATCH] PART 3: ScriptFunctionCall	none
[PATCH] PART 4: InspectorTypeBuilder	none
[PATCH] For Bots 1	none
[PATCH] PART 2: ScriptObject, ScriptValue (namespace Deprecated)	none
[PATCH] For Bots 2 (parts 1 and 2)	none
[PATCH] For Bots 3	eflews.bot: commit-queue-
[PATCH] For Bots 4	none
[PATCH] For Bots 5	eflews.bot: commit-queue-
[PATCH] For Bots 6	none
[PATCH] For Bots 7	none
[PATCH] For Bots 8	none
Patch	none
[DIFF] Windows Fixes	none

Joseph Pecoraro

Reported 2013-12-05 17:08:25 PST

To be able to inspect a JSContext start moving some core Inspector* classes and Script* that Inspector classes require. It would still be a long ways to go after these patches.

Attachments
[PATCH] PART 1: InspectAgentBase, InspectorAgentRegistry, InspectorBackendDispatcher, InspectorValues (236.93 KB, patch) 2013-12-05 17:13 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] PART 2: ScriptObject, ScriptValue (161.11 KB, patch) 2013-12-05 17:17 PST, Joseph Pecoraro	timothy: review+	Details Formatted Diff Diff
[PATCH] PART 3: ScriptFunctionCall (54.50 KB, patch) 2013-12-05 17:21 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] PART 4: InspectorTypeBuilder (292.83 KB, patch) 2013-12-05 17:26 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] For Bots 1 (236.61 KB, patch) 2013-12-06 16:42 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] PART 2: ScriptObject, ScriptValue (namespace Deprecated) (229.64 KB, patch) 2013-12-06 17:43 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] For Bots 2 (parts 1 and 2) (445.96 KB, patch) 2013-12-06 17:44 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] For Bots 3 (475.23 KB, patch) 2013-12-09 11:26 PST, Joseph Pecoraro	eflews.bot: commit-queue-	Details Formatted Diff Diff
[PATCH] For Bots 4 (477.97 KB, patch) 2013-12-09 13:09 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] For Bots 5 (714.07 KB, patch) 2013-12-09 13:48 PST, Joseph Pecoraro	eflews.bot: commit-queue-	Details Formatted Diff Diff
[PATCH] For Bots 6 (713.77 KB, patch) 2013-12-09 14:43 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] For Bots 7 (716.67 KB, patch) 2013-12-10 15:16 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] For Bots 8 (716.77 KB, patch) 2013-12-10 18:12 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Patch (883.59 KB, patch) 2013-12-11 14:03 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
[DIFF] Windows Fixes (9.75 KB, patch) 2013-12-11 14:23 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (14) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2013-12-05 17:13:41 PST

Created attachment 218556 [details] [PATCH] PART 1: InspectAgentBase, InspectorAgentRegistry, InspectorBackendDispatcher, InspectorValues

Joseph Pecoraro

Comment 2 2013-12-05 17:17:15 PST

Created attachment 218557 [details] [PATCH] PART 2: ScriptObject, ScriptValue

WebKit Commit Bot

Comment 3 2013-12-05 17:17:16 PST

Attachment 218556 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/InspectorAgentBase.h', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.h', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h', u'Source/JavaScriptCore/inspector/InspectorValues.cpp', u'Source/JavaScriptCore/inspector/InspectorValues.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentBase.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentRegistry.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorValues.h', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/ScriptProfile.cpp', u'Source/WebCore/bindings/js/ScriptProfile.h', u'Source/WebCore/bindings/js/ScriptValue.cpp', u'Source/WebCore/bindings/js/ScriptValue.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/CodeGeneratorInspector.py', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ConsoleMessage.h', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/ContentSearchUtils.h', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.cpp', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAgentBase.h', u'Source/WebCore/inspector/InspectorAgentRegistry.cpp', u'Source/WebCore/inspector/InspectorAgentRegistry.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/inspector/InspectorBaseAgent.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.h', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.h', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.h', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.h', u'Source/WebCore/inspector/InspectorDOMStorageAgent.cpp', u'Source/WebCore/inspector/InspectorDOMStorageAgent.h', u'Source/WebCore/inspector/InspectorDatabaseAgent.cpp', u'Source/WebCore/inspector/InspectorDatabaseAgent.h', u'Source/WebCore/inspector/InspectorDatabaseResource.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.h', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorIndexedDBAgent.h', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInputAgent.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.h', u'Source/WebCore/inspector/InspectorMemoryAgent.cpp', u'Source/WebCore/inspector/InspectorMemoryAgent.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.cpp', u'Source/WebCore/inspector/InspectorResourceAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.cpp', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.h', u'Source/WebCore/inspector/InspectorStyleTextEditor.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.h', u'Source/WebCore/inspector/InspectorValues.cpp', u'Source/WebCore/inspector/InspectorValues.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.h', u'Source/WebCore/inspector/ScriptArguments.cpp', u'Source/WebCore/inspector/ScriptCallFrame.cpp', u'Source/WebCore/inspector/ScriptCallFrame.h', u'Source/WebCore/inspector/ScriptCallStack.cpp', u'Source/WebCore/inspector/ScriptCallStack.h', u'Source/WebCore/inspector/TimelineRecordFactory.cpp', u'Source/WebCore/inspector/TimelineRecordFactory.h', u'Source/WebCore/inspector/WorkerConsoleAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/inspector/CodeGeneratorInspector.py:265: [RawTypes.BaseType.get_raw_validator_call_text] Class 'BaseType' has no 'get_validate_method_params' member [pylint/E1101] [5] ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:54: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCanvasAgent.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.cpp:620: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.cpp:63: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:46: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:49: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:51: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:54: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:55: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:56: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:92: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:388: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:426: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:429: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:472: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:473: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:510: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:611: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:615: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:701: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:709: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorTimelineAgent.cpp:585: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorWorkerAgent.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorLayerTreeAgent.h:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:97: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:50: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:73: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:87: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:110: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:111: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:130: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:131: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorInputAgent.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:561: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorWorkerAgent.cpp:112: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:50: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMDebuggerAgent.h:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:66: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorAgent.h:35: "InspectorAgentBase.h" already included at Source/WebCore/inspector/InspectorAgent.h:33 [build/include] [4] ERROR: Source/WebCore/inspector/InspectorResourceAgent.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorDatabaseAgent.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorCanvasAgent.cpp:67: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorConsoleAgent.h:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorPageAgent.h:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorMemoryAgent.cpp:90: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:54: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.cpp:60: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:356: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:215: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorConsoleAgent.cpp:64: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorHeapProfilerAgent.h:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorTimelineAgent.h:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorProfilerAgent.cpp:124: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorResourceAgent.cpp:654: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDatabaseAgent.cpp:214: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorMemoryAgent.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorAgent.cpp:63: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:74: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorAgentBase.h:27: #ifndef header guard has wrong style, please use: InspectorAgentBase_h [build/header_guard] [5] ERROR: Source/WebCore/inspector/InspectorInputAgent.cpp:57: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorProfilerAgent.h:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:60: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorApplicationCacheAgent.h:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 76 in 123 files If any of these errors are false positives, please file a bug against check-webkit-style.

Joseph Pecoraro

Comment 4 2013-12-05 17:21:59 PST

Created attachment 218558 [details] [PATCH] PART 3: ScriptFunctionCall

Joseph Pecoraro

Comment 5 2013-12-05 17:26:01 PST

Created attachment 218559 [details] [PATCH] PART 4: InspectorTypeBuilder

Sam Weinig

Comment 6 2013-12-05 17:43:39 PST

Two comments: - I'd rather we not move ScriptObject, ScriptValue and ScriptFunctionCall into the JSC namespace. They are unnecessary abstractions that should be removed. Instead, I would recommend moving them into a namespace Deprecated {} or some such. - Perhaps this Inspector infrastructure should move into its own static library like WTF is. There isn't a great reason it would belong in JSC.

EFL EWS Bot

Comment 7 2013-12-05 17:49:45 PST

Comment on attachment 218556 [details] [PATCH] PART 1: InspectAgentBase, InspectorAgentRegistry, InspectorBackendDispatcher, InspectorValues Attachment 218556 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/44818006

EFL EWS Bot

Comment 8 2013-12-05 18:19:51 PST

Comment on attachment 218556 [details] [PATCH] PART 1: InspectAgentBase, InspectorAgentRegistry, InspectorBackendDispatcher, InspectorValues Attachment 218556 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/44788010

kov's GTK+ EWS bot

Comment 9 2013-12-05 18:34:17 PST

Comment on attachment 218556 [details] [PATCH] PART 1: InspectAgentBase, InspectorAgentRegistry, InspectorBackendDispatcher, InspectorValues Attachment 218556 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/44878003

Timothy Hatcher

Comment 10 2013-12-06 12:51:48 PST

(In reply to comment #5) > Created an attachment (id=218559) [details] > [PATCH] PART 4: InspectorTypeBuilder (In reply to comment #6) > Two comments: > - I'd rather we not move ScriptObject, ScriptValue and ScriptFunctionCall into the JSC namespace. They are unnecessary abstractions that should be removed. Instead, I would recommend moving them into a namespace Deprecated {} or some such. I was wondering about this too. > - Perhaps this Inspector infrastructure should move into its own static library like WTF is. There isn't a great reason it would belong in JSC. I'm not sure about this. JSC will be a first-class Inspector host going forward. Geoff has agreed to putting these things into JSC.

Joseph Pecoraro

Comment 11 2013-12-06 13:48:54 PST

(In reply to comment #10) > (In reply to comment #5) > > Created an attachment (id=218559) [details] [details] > > [PATCH] PART 4: InspectorTypeBuilder > > (In reply to comment #6) > > Two comments: > > - I'd rather we not move ScriptObject, ScriptValue and ScriptFunctionCall into the JSC namespace. They are unnecessary abstractions that should be removed. Instead, I would recommend moving them into a namespace Deprecated {} or some such. > > I was wondering about this too. I'll make it namespace Deprecated. And I guess then I'll be explicit about Deprecated::ScriptValue and Deprecated::ScriptObject all over WebCore instead of "using namespace Deprecated". > > - Perhaps this Inspector infrastructure should move into its own static library like WTF is. There isn't a great reason it would belong in JSC. > > I'm not sure about this. JSC will be a first-class Inspector host going forward. Geoff has agreed to putting these things into JSC. I like the idea of moving out remote inspector stuff (JavaScriptCore/inspector/remote). Maybe also some of the core Inspector classes (the ones inevitably shared by JSC and WebCore and are therefore agnostic). However, as soon as you get into "inspector for JSContext" and "inspector for WebCore::Page" there is a lot of use of JSC/WebCore types. If separated, there would be a large private API surface area that would be easier if everyone didn't have to worry about exporting the right stuff. Its something I'm willing to look into though.

Joseph Pecoraro

Comment 12 2013-12-06 16:42:55 PST

Created attachment 218632 [details] [PATCH] For Bots 1

WebKit Commit Bot

Comment 13 2013-12-06 16:45:43 PST

Attachment 218632 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/InspectorAgentBase.h', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.h', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h', u'Source/JavaScriptCore/inspector/InspectorValues.cpp', u'Source/JavaScriptCore/inspector/InspectorValues.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentBase.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentRegistry.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorValues.h', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/ScriptProfile.cpp', u'Source/WebCore/bindings/js/ScriptProfile.h', u'Source/WebCore/bindings/js/ScriptValue.cpp', u'Source/WebCore/bindings/js/ScriptValue.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/CodeGeneratorInspector.py', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ConsoleMessage.h', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/ContentSearchUtils.h', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.cpp', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAgentRegistry.cpp', u'Source/WebCore/inspector/InspectorAgentRegistry.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/inspector/InspectorBaseAgent.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.h', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.h', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.h', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.h', u'Source/WebCore/inspector/InspectorDOMStorageAgent.cpp', u'Source/WebCore/inspector/InspectorDOMStorageAgent.h', u'Source/WebCore/inspector/InspectorDatabaseAgent.cpp', u'Source/WebCore/inspector/InspectorDatabaseAgent.h', u'Source/WebCore/inspector/InspectorDatabaseResource.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.h', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorIndexedDBAgent.h', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInputAgent.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.h', u'Source/WebCore/inspector/InspectorMemoryAgent.cpp', u'Source/WebCore/inspector/InspectorMemoryAgent.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.cpp', u'Source/WebCore/inspector/InspectorResourceAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.cpp', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.h', u'Source/WebCore/inspector/InspectorStyleTextEditor.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.h', u'Source/WebCore/inspector/InspectorValues.cpp', u'Source/WebCore/inspector/InspectorValues.h', u'Source/WebCore/inspector/InspectorWebAgentBase.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.h', u'Source/WebCore/inspector/ScriptArguments.cpp', u'Source/WebCore/inspector/ScriptCallFrame.cpp', u'Source/WebCore/inspector/ScriptCallFrame.h', u'Source/WebCore/inspector/ScriptCallStack.cpp', u'Source/WebCore/inspector/ScriptCallStack.h', u'Source/WebCore/inspector/TimelineRecordFactory.cpp', u'Source/WebCore/inspector/TimelineRecordFactory.h', u'Source/WebCore/inspector/WorkerConsoleAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/inspector/CodeGeneratorInspector.py:265: [RawTypes.BaseType.get_raw_validator_call_text] Class 'BaseType' has no 'get_validate_method_params' member [pylint/E1101] [5] ERROR: Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.cpp:620: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:46: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:49: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:51: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:54: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:55: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:56: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:92: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:388: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:426: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:429: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:472: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:473: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:510: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:611: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:615: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:701: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:709: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorTimelineAgent.cpp:585: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:97: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:50: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:73: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:87: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:110: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:111: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:130: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:131: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:561: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorWorkerAgent.cpp:112: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:50: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:66: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorCanvasAgent.cpp:67: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorMemoryAgent.cpp:90: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:356: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:215: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorConsoleAgent.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorProfilerAgent.cpp:124: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorResourceAgent.cpp:654: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDatabaseAgent.cpp:214: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorAgent.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:74: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorInputAgent.cpp:57: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 56 in 123 files If any of these errors are false positives, please file a bug against check-webkit-style.

Joseph Pecoraro

Comment 14 2013-12-06 17:43:10 PST

Created attachment 218637 [details] [PATCH] PART 2: ScriptObject, ScriptValue (namespace Deprecated) This uses namespace Deprecated for ScriptObject and ScriptValue, and I use fully qualified Deprecated::ScriptObject and Deprecated::ScriptValue everywhere in WebCore and later.

Joseph Pecoraro

Comment 15 2013-12-06 17:44:18 PST

Created attachment 218638 [details] [PATCH] For Bots 2 (parts 1 and 2)

Joseph Pecoraro

Comment 16 2013-12-06 18:49:18 PST

I don't understand how to fix the Windows build failures seen on the bots. On example: 1>WebCore.lib(InspectorAllInOne.obj) : error LNK2019: unresolved external symbol "public: bool __thiscall Inspector::InspectorBackendDispatcher::CallbackBase::isActive(void)const " (?isActive@CallbackBase@InspectorBackendDispatcher@Inspector@@QBE_NXZ) referenced in function "public: virtual bool __thiscall WebCore::`anonymous namespace'::TransactionCallback::handleEvent(class WebCore::SQLTransaction *)" (?handleEvent@TransactionCallback@?A0x62791c0a@WebCore@@UAE_NPAVSQLTransaction@3@@Z) Brent, any idea? Do I have to export the Inspector symbols for Windows somehow?

Joseph Pecoraro

Comment 17 2013-12-09 11:26:02 PST

Created attachment 218779 [details] [PATCH] For Bots 3

WebKit Commit Bot

Comment 18 2013-12-09 11:28:04 PST

Attachment 218779 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/copy-files.cmd', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.h', u'Source/JavaScriptCore/bindings/ScriptObject.cpp', u'Source/JavaScriptCore/bindings/ScriptObject.h', u'Source/JavaScriptCore/bindings/ScriptValue.cpp', u'Source/JavaScriptCore/bindings/ScriptValue.h', u'Source/JavaScriptCore/inspector/InspectorAgentBase.h', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.h', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h', u'Source/JavaScriptCore/inspector/InspectorValues.cpp', u'Source/JavaScriptCore/inspector/InspectorValues.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/bindings/ScriptFunctionCall.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptObject.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptValue.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentBase.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentRegistry.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorValues.h', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBAny.cpp', u'Source/WebCore/Modules/indexeddb/IDBAny.h', u'Source/WebCore/Modules/indexeddb/IDBCursor.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursor.h', u'Source/WebCore/Modules/indexeddb/IDBFactory.cpp', u'Source/WebCore/Modules/indexeddb/IDBFactory.h', u'Source/WebCore/Modules/indexeddb/IDBIndex.cpp', u'Source/WebCore/Modules/indexeddb/IDBIndex.h', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.h', u'Source/WebCore/Modules/indexeddb/IDBRequest.cpp', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/mediastream/CapabilityRange.cpp', u'Source/WebCore/Modules/mediastream/CapabilityRange.h', u'Source/WebCore/Modules/mediastream/MediaTrackConstraint.h', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.cpp', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.h', u'Source/WebCore/UseJSC.cmake', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/Dictionary.h', u'Source/WebCore/bindings/js/IDBBindingUtilities.cpp', u'Source/WebCore/bindings/js/IDBBindingUtilities.h', u'Source/WebCore/bindings/js/JSBindingsAllInOne.cpp', u'Source/WebCore/bindings/js/JSDictionary.cpp', u'Source/WebCore/bindings/js/JSDictionary.h', u'Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptManager.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.h', u'Source/WebCore/bindings/js/JSMessageEventCustom.cpp', u'Source/WebCore/bindings/js/ScheduledAction.cpp', u'Source/WebCore/bindings/js/ScriptCallStackFactory.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptController.h', u'Source/WebCore/bindings/js/ScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptDebugServer.h', u'Source/WebCore/bindings/js/ScriptFunctionCall.cpp', u'Source/WebCore/bindings/js/ScriptFunctionCall.h', u'Source/WebCore/bindings/js/ScriptGlobalObject.cpp', u'Source/WebCore/bindings/js/ScriptGlobalObject.h', u'Source/WebCore/bindings/js/ScriptObject.cpp', u'Source/WebCore/bindings/js/ScriptObject.h', u'Source/WebCore/bindings/js/ScriptProfile.cpp', u'Source/WebCore/bindings/js/ScriptProfile.h', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.h', u'Source/WebCore/bindings/js/ScriptState.h', u'Source/WebCore/bindings/js/ScriptValue.cpp', u'Source/WebCore/bindings/js/ScriptValue.h', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.h', u'Source/WebCore/bindings/js/WorkerScriptController.cpp', u'Source/WebCore/bindings/js/WorkerScriptController.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp', u'Source/WebCore/dom/CustomEvent.cpp', u'Source/WebCore/dom/CustomEvent.h', u'Source/WebCore/dom/MessageEvent.cpp', u'Source/WebCore/dom/MessageEvent.h', u'Source/WebCore/dom/PopStateEvent.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/CodeGeneratorInspector.py', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ConsoleMessage.h', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/ContentSearchUtils.h', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScript.h', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.cpp', u'Source/WebCore/inspector/InjectedScriptCanvasModule.h', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAgentRegistry.cpp', u'Source/WebCore/inspector/InspectorAgentRegistry.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/inspector/InspectorBaseAgent.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.h', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.h', u'Source/WebCore/inspector/InspectorCanvasInstrumentation.h', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.h', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.h', u'Source/WebCore/inspector/InspectorDOMStorageAgent.cpp', u'Source/WebCore/inspector/InspectorDOMStorageAgent.h', u'Source/WebCore/inspector/InspectorDatabaseAgent.cpp', u'Source/WebCore/inspector/InspectorDatabaseAgent.h', u'Source/WebCore/inspector/InspectorDatabaseResource.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.h', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorIndexedDBAgent.h', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInputAgent.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.h', u'Source/WebCore/inspector/InspectorMemoryAgent.cpp', u'Source/WebCore/inspector/InspectorMemoryAgent.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.cpp', u'Source/WebCore/inspector/InspectorResourceAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.cpp', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.h', u'Source/WebCore/inspector/InspectorStyleTextEditor.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.h', u'Source/WebCore/inspector/InspectorValues.cpp', u'Source/WebCore/inspector/InspectorValues.h', u'Source/WebCore/inspector/InspectorWebAgentBase.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.h', u'Source/WebCore/inspector/ScriptArguments.cpp', u'Source/WebCore/inspector/ScriptArguments.h', u'Source/WebCore/inspector/ScriptCallFrame.cpp', u'Source/WebCore/inspector/ScriptCallFrame.h', u'Source/WebCore/inspector/ScriptCallStack.cpp', u'Source/WebCore/inspector/ScriptCallStack.h', u'Source/WebCore/inspector/ScriptDebugListener.h', u'Source/WebCore/inspector/TimelineRecordFactory.cpp', u'Source/WebCore/inspector/TimelineRecordFactory.h', u'Source/WebCore/inspector/WorkerConsoleAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/testing/Internals.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerThread.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebFrame.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/inspector/CodeGeneratorInspector.py:265: [RawTypes.BaseType.get_raw_validator_call_text] Class 'BaseType' has no 'get_validate_method_params' member [pylint/E1101] [5] ERROR: Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.h:44: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:46: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:49: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:51: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:54: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:55: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:56: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:92: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:388: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:426: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:429: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:472: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:473: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:510: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:611: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:615: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:701: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:709: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorTimelineAgent.cpp:585: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptValue.h:51: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:215: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:97: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.cpp:51: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:50: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:73: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:87: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:110: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:111: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:130: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:131: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorProfilerAgent.cpp:124: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InjectedScript.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:47: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:56: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:75: The parameter name "handler" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorWorkerAgent.cpp:112: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:561: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.cpp:620: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:40: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:46: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCanvasAgent.cpp:67: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorMemoryAgent.cpp:90: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:356: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorInputAgent.cpp:57: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorConsoleAgent.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorResourceAgent.cpp:654: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:66: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorDatabaseAgent.cpp:214: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callData" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp:86: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:50: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorAgent.cpp:62: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:74: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 69 in 212 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 19 2013-12-09 11:50:26 PST

Comment on attachment 218779 [details] [PATCH] For Bots 3 Attachment 218779 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/47298166

Build Bot

Comment 20 2013-12-09 12:14:11 PST

Comment on attachment 218779 [details] [PATCH] For Bots 3 Attachment 218779 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/45898180

EFL EWS Bot

Comment 21 2013-12-09 12:51:27 PST

Comment on attachment 218779 [details] [PATCH] For Bots 3 Attachment 218779 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/47248179

Joseph Pecoraro

Comment 22 2013-12-09 13:09:47 PST

Created attachment 218794 [details] [PATCH] For Bots 4

WebKit Commit Bot

Comment 23 2013-12-09 13:13:10 PST

Attachment 218794 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/copy-files.cmd', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.h', u'Source/JavaScriptCore/bindings/ScriptObject.cpp', u'Source/JavaScriptCore/bindings/ScriptObject.h', u'Source/JavaScriptCore/bindings/ScriptValue.cpp', u'Source/JavaScriptCore/bindings/ScriptValue.h', u'Source/JavaScriptCore/inspector/InspectorAgentBase.h', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.h', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h', u'Source/JavaScriptCore/inspector/InspectorValues.cpp', u'Source/JavaScriptCore/inspector/InspectorValues.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/bindings/ScriptFunctionCall.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptObject.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptValue.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentBase.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentRegistry.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorValues.h', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBAny.cpp', u'Source/WebCore/Modules/indexeddb/IDBAny.h', u'Source/WebCore/Modules/indexeddb/IDBCursor.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursor.h', u'Source/WebCore/Modules/indexeddb/IDBFactory.cpp', u'Source/WebCore/Modules/indexeddb/IDBFactory.h', u'Source/WebCore/Modules/indexeddb/IDBIndex.cpp', u'Source/WebCore/Modules/indexeddb/IDBIndex.h', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.h', u'Source/WebCore/Modules/indexeddb/IDBRequest.cpp', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/mediastream/CapabilityRange.cpp', u'Source/WebCore/Modules/mediastream/CapabilityRange.h', u'Source/WebCore/Modules/mediastream/MediaTrackConstraint.h', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.cpp', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.h', u'Source/WebCore/UseJSC.cmake', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/Dictionary.h', u'Source/WebCore/bindings/js/IDBBindingUtilities.cpp', u'Source/WebCore/bindings/js/IDBBindingUtilities.h', u'Source/WebCore/bindings/js/JSBindingsAllInOne.cpp', u'Source/WebCore/bindings/js/JSDictionary.cpp', u'Source/WebCore/bindings/js/JSDictionary.h', u'Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptManager.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.h', u'Source/WebCore/bindings/js/JSMessageEventCustom.cpp', u'Source/WebCore/bindings/js/ScheduledAction.cpp', u'Source/WebCore/bindings/js/ScriptCallStackFactory.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptController.h', u'Source/WebCore/bindings/js/ScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptDebugServer.h', u'Source/WebCore/bindings/js/ScriptFunctionCall.cpp', u'Source/WebCore/bindings/js/ScriptFunctionCall.h', u'Source/WebCore/bindings/js/ScriptGlobalObject.cpp', u'Source/WebCore/bindings/js/ScriptGlobalObject.h', u'Source/WebCore/bindings/js/ScriptObject.cpp', u'Source/WebCore/bindings/js/ScriptObject.h', u'Source/WebCore/bindings/js/ScriptProfile.cpp', u'Source/WebCore/bindings/js/ScriptProfile.h', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.h', u'Source/WebCore/bindings/js/ScriptState.h', u'Source/WebCore/bindings/js/ScriptValue.cpp', u'Source/WebCore/bindings/js/ScriptValue.h', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.h', u'Source/WebCore/bindings/js/WorkerScriptController.cpp', u'Source/WebCore/bindings/js/WorkerScriptController.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp', u'Source/WebCore/dom/CustomEvent.cpp', u'Source/WebCore/dom/CustomEvent.h', u'Source/WebCore/dom/MessageEvent.cpp', u'Source/WebCore/dom/MessageEvent.h', u'Source/WebCore/dom/PopStateEvent.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/CodeGeneratorInspector.py', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ConsoleMessage.h', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/ContentSearchUtils.h', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScript.h', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.cpp', u'Source/WebCore/inspector/InjectedScriptCanvasModule.h', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAgentRegistry.cpp', u'Source/WebCore/inspector/InspectorAgentRegistry.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/inspector/InspectorBaseAgent.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.h', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.h', u'Source/WebCore/inspector/InspectorCanvasInstrumentation.h', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.h', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.h', u'Source/WebCore/inspector/InspectorDOMStorageAgent.cpp', u'Source/WebCore/inspector/InspectorDOMStorageAgent.h', u'Source/WebCore/inspector/InspectorDatabaseAgent.cpp', u'Source/WebCore/inspector/InspectorDatabaseAgent.h', u'Source/WebCore/inspector/InspectorDatabaseResource.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.h', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorIndexedDBAgent.h', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInputAgent.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.h', u'Source/WebCore/inspector/InspectorMemoryAgent.cpp', u'Source/WebCore/inspector/InspectorMemoryAgent.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.cpp', u'Source/WebCore/inspector/InspectorResourceAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.cpp', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.h', u'Source/WebCore/inspector/InspectorStyleTextEditor.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.h', u'Source/WebCore/inspector/InspectorValues.cpp', u'Source/WebCore/inspector/InspectorValues.h', u'Source/WebCore/inspector/InspectorWebAgentBase.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.h', u'Source/WebCore/inspector/ScriptArguments.cpp', u'Source/WebCore/inspector/ScriptArguments.h', u'Source/WebCore/inspector/ScriptCallFrame.cpp', u'Source/WebCore/inspector/ScriptCallFrame.h', u'Source/WebCore/inspector/ScriptCallStack.cpp', u'Source/WebCore/inspector/ScriptCallStack.h', u'Source/WebCore/inspector/ScriptDebugListener.h', u'Source/WebCore/inspector/TimelineRecordFactory.cpp', u'Source/WebCore/inspector/TimelineRecordFactory.h', u'Source/WebCore/inspector/WorkerConsoleAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/testing/Internals.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerThread.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebFrame.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/inspector/CodeGeneratorInspector.py:265: [RawTypes.BaseType.get_raw_validator_call_text] Class 'BaseType' has no 'get_validate_method_params' member [pylint/E1101] [5] ERROR: Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.h:44: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:46: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:49: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:51: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:54: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:55: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:56: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:92: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:388: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:426: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:429: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:472: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:473: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:510: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:611: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:615: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:701: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:709: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorTimelineAgent.cpp:585: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptValue.h:51: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:215: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:97: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.cpp:51: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:50: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:73: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:87: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:110: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:111: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:130: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:131: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorProfilerAgent.cpp:124: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InjectedScript.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:47: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:56: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:75: The parameter name "handler" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorWorkerAgent.cpp:112: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:561: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.cpp:620: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:40: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:46: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCanvasAgent.cpp:67: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorMemoryAgent.cpp:90: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:356: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorInputAgent.cpp:57: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorConsoleAgent.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorResourceAgent.cpp:654: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:66: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorDatabaseAgent.cpp:214: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callData" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp:86: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:50: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorAgent.cpp:62: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:74: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 69 in 216 files If any of these errors are false positives, please file a bug against check-webkit-style.

Joseph Pecoraro

Comment 24 2013-12-09 13:48:15 PST

Created attachment 218796 [details] [PATCH] For Bots 5 This one contains all the parts, since it looks good for parts 1-3!

WebKit Commit Bot

Comment 25 2013-12-09 13:51:47 PST

Attachment 218796 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/copy-files.cmd', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.h', u'Source/JavaScriptCore/bindings/ScriptObject.cpp', u'Source/JavaScriptCore/bindings/ScriptObject.h', u'Source/JavaScriptCore/bindings/ScriptValue.cpp', u'Source/JavaScriptCore/bindings/ScriptValue.h', u'Source/JavaScriptCore/inspector/InspectorAgentBase.h', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.h', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h', u'Source/JavaScriptCore/inspector/InspectorTypeBuilder.h', u'Source/JavaScriptCore/inspector/InspectorValues.cpp', u'Source/JavaScriptCore/inspector/InspectorValues.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/bindings/ScriptFunctionCall.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptObject.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptValue.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentBase.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentRegistry.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorTypeBuilder.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorValues.h', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBAny.cpp', u'Source/WebCore/Modules/indexeddb/IDBAny.h', u'Source/WebCore/Modules/indexeddb/IDBCursor.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursor.h', u'Source/WebCore/Modules/indexeddb/IDBFactory.cpp', u'Source/WebCore/Modules/indexeddb/IDBFactory.h', u'Source/WebCore/Modules/indexeddb/IDBIndex.cpp', u'Source/WebCore/Modules/indexeddb/IDBIndex.h', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.h', u'Source/WebCore/Modules/indexeddb/IDBRequest.cpp', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/mediastream/CapabilityRange.cpp', u'Source/WebCore/Modules/mediastream/CapabilityRange.h', u'Source/WebCore/Modules/mediastream/MediaTrackConstraint.h', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.cpp', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.h', u'Source/WebCore/UseJSC.cmake', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/Dictionary.h', u'Source/WebCore/bindings/js/IDBBindingUtilities.cpp', u'Source/WebCore/bindings/js/IDBBindingUtilities.h', u'Source/WebCore/bindings/js/JSBindingsAllInOne.cpp', u'Source/WebCore/bindings/js/JSDictionary.cpp', u'Source/WebCore/bindings/js/JSDictionary.h', u'Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptManager.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.h', u'Source/WebCore/bindings/js/JSMessageEventCustom.cpp', u'Source/WebCore/bindings/js/ScheduledAction.cpp', u'Source/WebCore/bindings/js/ScriptCallStackFactory.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptController.h', u'Source/WebCore/bindings/js/ScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptDebugServer.h', u'Source/WebCore/bindings/js/ScriptFunctionCall.cpp', u'Source/WebCore/bindings/js/ScriptFunctionCall.h', u'Source/WebCore/bindings/js/ScriptGlobalObject.cpp', u'Source/WebCore/bindings/js/ScriptGlobalObject.h', u'Source/WebCore/bindings/js/ScriptObject.cpp', u'Source/WebCore/bindings/js/ScriptObject.h', u'Source/WebCore/bindings/js/ScriptProfile.cpp', u'Source/WebCore/bindings/js/ScriptProfile.h', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.h', u'Source/WebCore/bindings/js/ScriptState.h', u'Source/WebCore/bindings/js/ScriptValue.cpp', u'Source/WebCore/bindings/js/ScriptValue.h', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.h', u'Source/WebCore/bindings/js/WorkerScriptController.cpp', u'Source/WebCore/bindings/js/WorkerScriptController.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp', u'Source/WebCore/dom/CustomEvent.cpp', u'Source/WebCore/dom/CustomEvent.h', u'Source/WebCore/dom/MessageEvent.cpp', u'Source/WebCore/dom/MessageEvent.h', u'Source/WebCore/dom/PopStateEvent.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/CodeGeneratorInspector.py', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ConsoleMessage.h', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/ContentSearchUtils.h', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScript.h', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.cpp', u'Source/WebCore/inspector/InjectedScriptCanvasModule.h', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAgentRegistry.cpp', u'Source/WebCore/inspector/InspectorAgentRegistry.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/inspector/InspectorBaseAgent.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.h', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.h', u'Source/WebCore/inspector/InspectorCanvasInstrumentation.h', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.h', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.h', u'Source/WebCore/inspector/InspectorDOMStorageAgent.cpp', u'Source/WebCore/inspector/InspectorDOMStorageAgent.h', u'Source/WebCore/inspector/InspectorDatabaseAgent.cpp', u'Source/WebCore/inspector/InspectorDatabaseAgent.h', u'Source/WebCore/inspector/InspectorDatabaseResource.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.h', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorIndexedDBAgent.h', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInputAgent.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.h', u'Source/WebCore/inspector/InspectorMemoryAgent.cpp', u'Source/WebCore/inspector/InspectorMemoryAgent.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.cpp', u'Source/WebCore/inspector/InspectorResourceAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.cpp', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.h', u'Source/WebCore/inspector/InspectorStyleTextEditor.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.h', u'Source/WebCore/inspector/InspectorValues.cpp', u'Source/WebCore/inspector/InspectorValues.h', u'Source/WebCore/inspector/InspectorWebAgentBase.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.h', u'Source/WebCore/inspector/ScriptArguments.cpp', u'Source/WebCore/inspector/ScriptArguments.h', u'Source/WebCore/inspector/ScriptCallFrame.cpp', u'Source/WebCore/inspector/ScriptCallFrame.h', u'Source/WebCore/inspector/ScriptCallStack.cpp', u'Source/WebCore/inspector/ScriptCallStack.h', u'Source/WebCore/inspector/ScriptDebugListener.h', u'Source/WebCore/inspector/TimelineRecordFactory.cpp', u'Source/WebCore/inspector/TimelineRecordFactory.h', u'Source/WebCore/inspector/WorkerConsoleAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/testing/Internals.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerThread.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebFrame.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/inspector/CodeGeneratorInspector.py:265: [RawTypes.BaseType.get_raw_validator_call_text] Class 'BaseType' has no 'get_validate_method_params' member [pylint/E1101] [5] ERROR: Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.h:44: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:117: The parameter name "pseudoIdMatches" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:77: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:46: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:49: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:51: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:54: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:55: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:56: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:92: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:388: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:426: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:429: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:472: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:473: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:510: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:611: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:615: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:701: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:709: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorTimelineAgent.cpp:585: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptValue.h:51: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:215: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:97: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.cpp:51: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:50: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:73: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:87: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:110: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:111: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:130: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:131: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorProfilerAgent.cpp:124: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InjectedScript.h:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:47: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:56: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:75: The parameter name "handler" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorWorkerAgent.cpp:112: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:561: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.cpp:620: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:72: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:81: cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:85: ExactlyInt::cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:88: ExactlyInt::cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:88: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:40: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:46: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCanvasAgent.cpp:67: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorMemoryAgent.cpp:90: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:356: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorInputAgent.cpp:57: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorConsoleAgent.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorResourceAgent.cpp:654: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:66: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorDatabaseAgent.cpp:214: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callData" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp:86: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:50: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorAgent.cpp:62: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:74: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 84 in 223 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 26 2013-12-09 13:54:02 PST

Comment on attachment 218796 [details] [PATCH] For Bots 5 Attachment 218796 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/45898214

EFL EWS Bot

Comment 27 2013-12-09 13:59:21 PST

Comment on attachment 218796 [details] [PATCH] For Bots 5 Attachment 218796 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/47208203

Joseph Pecoraro

Comment 28 2013-12-09 14:43:14 PST

Created attachment 218804 [details] [PATCH] For Bots 6

WebKit Commit Bot

Comment 29 2013-12-09 14:45:33 PST

Attachment 218804 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/copy-files.cmd', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.h', u'Source/JavaScriptCore/bindings/ScriptObject.cpp', u'Source/JavaScriptCore/bindings/ScriptObject.h', u'Source/JavaScriptCore/bindings/ScriptValue.cpp', u'Source/JavaScriptCore/bindings/ScriptValue.h', u'Source/JavaScriptCore/inspector/InspectorAgentBase.h', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.h', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h', u'Source/JavaScriptCore/inspector/InspectorTypeBuilder.h', u'Source/JavaScriptCore/inspector/InspectorValues.cpp', u'Source/JavaScriptCore/inspector/InspectorValues.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/bindings/ScriptFunctionCall.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptObject.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptValue.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentBase.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentRegistry.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorTypeBuilder.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorValues.h', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBAny.cpp', u'Source/WebCore/Modules/indexeddb/IDBAny.h', u'Source/WebCore/Modules/indexeddb/IDBCursor.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursor.h', u'Source/WebCore/Modules/indexeddb/IDBFactory.cpp', u'Source/WebCore/Modules/indexeddb/IDBFactory.h', u'Source/WebCore/Modules/indexeddb/IDBIndex.cpp', u'Source/WebCore/Modules/indexeddb/IDBIndex.h', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.h', u'Source/WebCore/Modules/indexeddb/IDBRequest.cpp', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/mediastream/CapabilityRange.cpp', u'Source/WebCore/Modules/mediastream/CapabilityRange.h', u'Source/WebCore/Modules/mediastream/MediaTrackConstraint.h', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.cpp', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.h', u'Source/WebCore/UseJSC.cmake', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/Dictionary.h', u'Source/WebCore/bindings/js/IDBBindingUtilities.cpp', u'Source/WebCore/bindings/js/IDBBindingUtilities.h', u'Source/WebCore/bindings/js/JSBindingsAllInOne.cpp', u'Source/WebCore/bindings/js/JSDictionary.cpp', u'Source/WebCore/bindings/js/JSDictionary.h', u'Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptManager.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.h', u'Source/WebCore/bindings/js/JSMessageEventCustom.cpp', u'Source/WebCore/bindings/js/ScheduledAction.cpp', u'Source/WebCore/bindings/js/ScriptCallStackFactory.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptController.h', u'Source/WebCore/bindings/js/ScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptDebugServer.h', u'Source/WebCore/bindings/js/ScriptFunctionCall.cpp', u'Source/WebCore/bindings/js/ScriptFunctionCall.h', u'Source/WebCore/bindings/js/ScriptGlobalObject.cpp', u'Source/WebCore/bindings/js/ScriptGlobalObject.h', u'Source/WebCore/bindings/js/ScriptObject.cpp', u'Source/WebCore/bindings/js/ScriptObject.h', u'Source/WebCore/bindings/js/ScriptProfile.cpp', u'Source/WebCore/bindings/js/ScriptProfile.h', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.h', u'Source/WebCore/bindings/js/ScriptState.h', u'Source/WebCore/bindings/js/ScriptValue.cpp', u'Source/WebCore/bindings/js/ScriptValue.h', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.h', u'Source/WebCore/bindings/js/WorkerScriptController.cpp', u'Source/WebCore/bindings/js/WorkerScriptController.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp', u'Source/WebCore/dom/CustomEvent.cpp', u'Source/WebCore/dom/CustomEvent.h', u'Source/WebCore/dom/MessageEvent.cpp', u'Source/WebCore/dom/MessageEvent.h', u'Source/WebCore/dom/PopStateEvent.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/CodeGeneratorInspector.py', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ConsoleMessage.h', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/ContentSearchUtils.h', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScript.h', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.cpp', u'Source/WebCore/inspector/InjectedScriptCanvasModule.h', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAgentRegistry.cpp', u'Source/WebCore/inspector/InspectorAgentRegistry.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/inspector/InspectorBaseAgent.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.h', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.h', u'Source/WebCore/inspector/InspectorCanvasInstrumentation.h', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.h', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.h', u'Source/WebCore/inspector/InspectorDOMStorageAgent.cpp', u'Source/WebCore/inspector/InspectorDOMStorageAgent.h', u'Source/WebCore/inspector/InspectorDatabaseAgent.cpp', u'Source/WebCore/inspector/InspectorDatabaseAgent.h', u'Source/WebCore/inspector/InspectorDatabaseResource.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.h', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorIndexedDBAgent.h', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInputAgent.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.h', u'Source/WebCore/inspector/InspectorMemoryAgent.cpp', u'Source/WebCore/inspector/InspectorMemoryAgent.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.cpp', u'Source/WebCore/inspector/InspectorResourceAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.cpp', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.h', u'Source/WebCore/inspector/InspectorStyleTextEditor.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.h', u'Source/WebCore/inspector/InspectorValues.cpp', u'Source/WebCore/inspector/InspectorValues.h', u'Source/WebCore/inspector/InspectorWebAgentBase.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.h', u'Source/WebCore/inspector/ScriptArguments.cpp', u'Source/WebCore/inspector/ScriptArguments.h', u'Source/WebCore/inspector/ScriptCallFrame.cpp', u'Source/WebCore/inspector/ScriptCallFrame.h', u'Source/WebCore/inspector/ScriptCallStack.cpp', u'Source/WebCore/inspector/ScriptCallStack.h', u'Source/WebCore/inspector/ScriptDebugListener.h', u'Source/WebCore/inspector/TimelineRecordFactory.cpp', u'Source/WebCore/inspector/TimelineRecordFactory.h', u'Source/WebCore/inspector/WorkerConsoleAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/testing/Internals.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerThread.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebFrame.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/inspector/CodeGeneratorInspector.py:265: [RawTypes.BaseType.get_raw_validator_call_text] Class 'BaseType' has no 'get_validate_method_params' member [pylint/E1101] [5] ERROR: Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.h:44: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:117: The parameter name "pseudoIdMatches" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:77: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:46: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:49: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:51: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:54: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:55: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:56: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:92: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:388: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:426: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:429: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:472: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:473: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:510: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:611: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:615: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:701: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:709: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorTimelineAgent.cpp:585: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptValue.h:51: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:215: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:97: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.cpp:51: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:50: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:73: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:87: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:110: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:111: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:130: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:131: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorProfilerAgent.cpp:124: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InjectedScript.h:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:47: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:56: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:75: The parameter name "handler" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorWorkerAgent.cpp:112: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:561: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.cpp:620: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:72: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:81: cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:85: ExactlyInt::cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:88: ExactlyInt::cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:88: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:40: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:46: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCanvasAgent.cpp:67: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorMemoryAgent.cpp:90: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:356: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorInputAgent.cpp:57: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorConsoleAgent.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorResourceAgent.cpp:654: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:66: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorDatabaseAgent.cpp:214: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callData" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp:86: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:50: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorAgent.cpp:62: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:74: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 84 in 223 files If any of these errors are false positives, please file a bug against check-webkit-style.

Joseph Pecoraro

Comment 30 2013-12-10 15:16:38 PST

Created attachment 218912 [details] [PATCH] For Bots 7 Attempt at fixing Windows.

WebKit Commit Bot

Comment 31 2013-12-10 15:19:42 PST

Attachment 218912 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/copy-files.cmd', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.h', u'Source/JavaScriptCore/bindings/ScriptObject.cpp', u'Source/JavaScriptCore/bindings/ScriptObject.h', u'Source/JavaScriptCore/bindings/ScriptValue.cpp', u'Source/JavaScriptCore/bindings/ScriptValue.h', u'Source/JavaScriptCore/inspector/InspectorAgentBase.h', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.h', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h', u'Source/JavaScriptCore/inspector/InspectorTypeBuilder.h', u'Source/JavaScriptCore/inspector/InspectorValues.cpp', u'Source/JavaScriptCore/inspector/InspectorValues.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/bindings/ScriptFunctionCall.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptObject.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptValue.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentBase.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentRegistry.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorTypeBuilder.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorValues.h', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBAny.cpp', u'Source/WebCore/Modules/indexeddb/IDBAny.h', u'Source/WebCore/Modules/indexeddb/IDBCursor.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursor.h', u'Source/WebCore/Modules/indexeddb/IDBFactory.cpp', u'Source/WebCore/Modules/indexeddb/IDBFactory.h', u'Source/WebCore/Modules/indexeddb/IDBIndex.cpp', u'Source/WebCore/Modules/indexeddb/IDBIndex.h', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.h', u'Source/WebCore/Modules/indexeddb/IDBRequest.cpp', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/mediastream/CapabilityRange.cpp', u'Source/WebCore/Modules/mediastream/CapabilityRange.h', u'Source/WebCore/Modules/mediastream/MediaTrackConstraint.h', u'Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.cpp', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.h', u'Source/WebCore/UseJSC.cmake', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/Dictionary.h', u'Source/WebCore/bindings/js/IDBBindingUtilities.cpp', u'Source/WebCore/bindings/js/IDBBindingUtilities.h', u'Source/WebCore/bindings/js/JSBindingsAllInOne.cpp', u'Source/WebCore/bindings/js/JSDictionary.cpp', u'Source/WebCore/bindings/js/JSDictionary.h', u'Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptManager.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.h', u'Source/WebCore/bindings/js/JSMessageEventCustom.cpp', u'Source/WebCore/bindings/js/ScheduledAction.cpp', u'Source/WebCore/bindings/js/ScriptCallStackFactory.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptController.h', u'Source/WebCore/bindings/js/ScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptDebugServer.h', u'Source/WebCore/bindings/js/ScriptFunctionCall.cpp', u'Source/WebCore/bindings/js/ScriptFunctionCall.h', u'Source/WebCore/bindings/js/ScriptGlobalObject.cpp', u'Source/WebCore/bindings/js/ScriptGlobalObject.h', u'Source/WebCore/bindings/js/ScriptObject.cpp', u'Source/WebCore/bindings/js/ScriptObject.h', u'Source/WebCore/bindings/js/ScriptProfile.cpp', u'Source/WebCore/bindings/js/ScriptProfile.h', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.h', u'Source/WebCore/bindings/js/ScriptState.h', u'Source/WebCore/bindings/js/ScriptValue.cpp', u'Source/WebCore/bindings/js/ScriptValue.h', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.h', u'Source/WebCore/bindings/js/WorkerScriptController.cpp', u'Source/WebCore/bindings/js/WorkerScriptController.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp', u'Source/WebCore/dom/CustomEvent.cpp', u'Source/WebCore/dom/CustomEvent.h', u'Source/WebCore/dom/MessageEvent.cpp', u'Source/WebCore/dom/MessageEvent.h', u'Source/WebCore/dom/PopStateEvent.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/CodeGeneratorInspector.py', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ConsoleMessage.h', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/ContentSearchUtils.h', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScript.h', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.cpp', u'Source/WebCore/inspector/InjectedScriptCanvasModule.h', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAgentRegistry.cpp', u'Source/WebCore/inspector/InspectorAgentRegistry.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/inspector/InspectorBaseAgent.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.h', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.h', u'Source/WebCore/inspector/InspectorCanvasInstrumentation.h', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.h', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.h', u'Source/WebCore/inspector/InspectorDOMStorageAgent.cpp', u'Source/WebCore/inspector/InspectorDOMStorageAgent.h', u'Source/WebCore/inspector/InspectorDatabaseAgent.cpp', u'Source/WebCore/inspector/InspectorDatabaseAgent.h', u'Source/WebCore/inspector/InspectorDatabaseResource.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.h', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorIndexedDBAgent.h', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInputAgent.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.h', u'Source/WebCore/inspector/InspectorMemoryAgent.cpp', u'Source/WebCore/inspector/InspectorMemoryAgent.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.cpp', u'Source/WebCore/inspector/InspectorResourceAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.cpp', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.h', u'Source/WebCore/inspector/InspectorStyleTextEditor.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.h', u'Source/WebCore/inspector/InspectorValues.cpp', u'Source/WebCore/inspector/InspectorValues.h', u'Source/WebCore/inspector/InspectorWebAgentBase.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.h', u'Source/WebCore/inspector/ScriptArguments.cpp', u'Source/WebCore/inspector/ScriptArguments.h', u'Source/WebCore/inspector/ScriptCallFrame.cpp', u'Source/WebCore/inspector/ScriptCallFrame.h', u'Source/WebCore/inspector/ScriptCallStack.cpp', u'Source/WebCore/inspector/ScriptCallStack.h', u'Source/WebCore/inspector/ScriptDebugListener.h', u'Source/WebCore/inspector/TimelineRecordFactory.cpp', u'Source/WebCore/inspector/TimelineRecordFactory.h', u'Source/WebCore/inspector/WorkerConsoleAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/testing/Internals.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerThread.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebFrame.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/inspector/CodeGeneratorInspector.py:265: [RawTypes.BaseType.get_raw_validator_call_text] Class 'BaseType' has no 'get_validate_method_params' member [pylint/E1101] [5] ERROR: Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.h:44: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:117: The parameter name "pseudoIdMatches" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:75: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:46: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:49: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:51: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:54: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:55: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:56: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:92: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:388: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:426: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:429: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:472: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:473: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:510: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:611: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:615: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:701: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:709: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorTimelineAgent.cpp:585: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptValue.h:51: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:215: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:97: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.cpp:51: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:50: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:73: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:87: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:110: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:111: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:130: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:131: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorProfilerAgent.cpp:124: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InjectedScript.h:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:47: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:56: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:75: The parameter name "handler" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorWorkerAgent.cpp:112: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:561: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.cpp:620: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:72: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:81: cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:85: ExactlyInt::cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:88: ExactlyInt::cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:88: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:40: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:46: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCanvasAgent.cpp:67: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorMemoryAgent.cpp:90: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:356: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorInputAgent.cpp:57: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorConsoleAgent.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorResourceAgent.cpp:654: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:66: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorDatabaseAgent.cpp:214: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callData" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp:86: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:50: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorAgent.cpp:62: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:74: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 84 in 223 files If any of these errors are false positives, please file a bug against check-webkit-style.

Joseph Pecoraro

Comment 32 2013-12-10 18:12:10 PST

Created attachment 218929 [details] [PATCH] For Bots 8 Yet another attempt to get the Windows bot to look at the patch.

WebKit Commit Bot

Comment 33 2013-12-10 18:14:42 PST

Attachment 218929 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/copy-files.cmd', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.h', u'Source/JavaScriptCore/bindings/ScriptObject.cpp', u'Source/JavaScriptCore/bindings/ScriptObject.h', u'Source/JavaScriptCore/bindings/ScriptValue.cpp', u'Source/JavaScriptCore/bindings/ScriptValue.h', u'Source/JavaScriptCore/inspector/InspectorAgentBase.h', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.h', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h', u'Source/JavaScriptCore/inspector/InspectorTypeBuilder.h', u'Source/JavaScriptCore/inspector/InspectorValues.cpp', u'Source/JavaScriptCore/inspector/InspectorValues.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/bindings/ScriptFunctionCall.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptObject.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptValue.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentBase.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentRegistry.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorTypeBuilder.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorValues.h', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBAny.cpp', u'Source/WebCore/Modules/indexeddb/IDBAny.h', u'Source/WebCore/Modules/indexeddb/IDBCursor.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursor.h', u'Source/WebCore/Modules/indexeddb/IDBFactory.cpp', u'Source/WebCore/Modules/indexeddb/IDBFactory.h', u'Source/WebCore/Modules/indexeddb/IDBIndex.cpp', u'Source/WebCore/Modules/indexeddb/IDBIndex.h', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.h', u'Source/WebCore/Modules/indexeddb/IDBRequest.cpp', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/mediastream/CapabilityRange.cpp', u'Source/WebCore/Modules/mediastream/CapabilityRange.h', u'Source/WebCore/Modules/mediastream/MediaTrackConstraint.h', u'Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.cpp', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.h', u'Source/WebCore/UseJSC.cmake', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/Dictionary.h', u'Source/WebCore/bindings/js/IDBBindingUtilities.cpp', u'Source/WebCore/bindings/js/IDBBindingUtilities.h', u'Source/WebCore/bindings/js/JSBindingsAllInOne.cpp', u'Source/WebCore/bindings/js/JSDictionary.cpp', u'Source/WebCore/bindings/js/JSDictionary.h', u'Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptManager.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.h', u'Source/WebCore/bindings/js/JSMessageEventCustom.cpp', u'Source/WebCore/bindings/js/ScheduledAction.cpp', u'Source/WebCore/bindings/js/ScriptCallStackFactory.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptController.h', u'Source/WebCore/bindings/js/ScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptDebugServer.h', u'Source/WebCore/bindings/js/ScriptFunctionCall.cpp', u'Source/WebCore/bindings/js/ScriptFunctionCall.h', u'Source/WebCore/bindings/js/ScriptGlobalObject.cpp', u'Source/WebCore/bindings/js/ScriptGlobalObject.h', u'Source/WebCore/bindings/js/ScriptObject.cpp', u'Source/WebCore/bindings/js/ScriptObject.h', u'Source/WebCore/bindings/js/ScriptProfile.cpp', u'Source/WebCore/bindings/js/ScriptProfile.h', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.h', u'Source/WebCore/bindings/js/ScriptState.h', u'Source/WebCore/bindings/js/ScriptValue.cpp', u'Source/WebCore/bindings/js/ScriptValue.h', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.h', u'Source/WebCore/bindings/js/WorkerScriptController.cpp', u'Source/WebCore/bindings/js/WorkerScriptController.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp', u'Source/WebCore/dom/CustomEvent.cpp', u'Source/WebCore/dom/CustomEvent.h', u'Source/WebCore/dom/MessageEvent.cpp', u'Source/WebCore/dom/MessageEvent.h', u'Source/WebCore/dom/PopStateEvent.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/CodeGeneratorInspector.py', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ConsoleMessage.h', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/ContentSearchUtils.h', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScript.h', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.cpp', u'Source/WebCore/inspector/InjectedScriptCanvasModule.h', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAgentRegistry.cpp', u'Source/WebCore/inspector/InspectorAgentRegistry.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/inspector/InspectorBaseAgent.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.h', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.h', u'Source/WebCore/inspector/InspectorCanvasInstrumentation.h', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.h', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.h', u'Source/WebCore/inspector/InspectorDOMStorageAgent.cpp', u'Source/WebCore/inspector/InspectorDOMStorageAgent.h', u'Source/WebCore/inspector/InspectorDatabaseAgent.cpp', u'Source/WebCore/inspector/InspectorDatabaseAgent.h', u'Source/WebCore/inspector/InspectorDatabaseResource.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.h', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorIndexedDBAgent.h', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInputAgent.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.h', u'Source/WebCore/inspector/InspectorMemoryAgent.cpp', u'Source/WebCore/inspector/InspectorMemoryAgent.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.cpp', u'Source/WebCore/inspector/InspectorResourceAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.cpp', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.h', u'Source/WebCore/inspector/InspectorStyleTextEditor.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.h', u'Source/WebCore/inspector/InspectorValues.cpp', u'Source/WebCore/inspector/InspectorValues.h', u'Source/WebCore/inspector/InspectorWebAgentBase.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.h', u'Source/WebCore/inspector/ScriptArguments.cpp', u'Source/WebCore/inspector/ScriptArguments.h', u'Source/WebCore/inspector/ScriptCallFrame.cpp', u'Source/WebCore/inspector/ScriptCallFrame.h', u'Source/WebCore/inspector/ScriptCallStack.cpp', u'Source/WebCore/inspector/ScriptCallStack.h', u'Source/WebCore/inspector/ScriptDebugListener.h', u'Source/WebCore/inspector/TimelineRecordFactory.cpp', u'Source/WebCore/inspector/TimelineRecordFactory.h', u'Source/WebCore/inspector/WorkerConsoleAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/testing/Internals.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerThread.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebFrame.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/inspector/CodeGeneratorInspector.py:265: [RawTypes.BaseType.get_raw_validator_call_text] Class 'BaseType' has no 'get_validate_method_params' member [pylint/E1101] [5] ERROR: Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.h:44: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:117: The parameter name "pseudoIdMatches" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:75: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:46: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:49: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:51: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:54: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:55: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:56: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:92: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:388: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:426: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:429: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:472: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:473: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:510: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:611: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:615: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:701: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:709: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorTimelineAgent.cpp:585: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptValue.h:51: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:215: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:97: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.cpp:51: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:50: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:73: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:87: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:110: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:111: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:130: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:131: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorProfilerAgent.cpp:124: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InjectedScript.h:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:47: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:56: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:75: The parameter name "handler" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorWorkerAgent.cpp:112: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:561: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.cpp:620: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:72: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:81: cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:85: ExactlyInt::cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:88: ExactlyInt::cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:88: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:40: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:46: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCanvasAgent.cpp:67: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorMemoryAgent.cpp:90: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:356: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorInputAgent.cpp:57: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorConsoleAgent.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorResourceAgent.cpp:654: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:66: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorDatabaseAgent.cpp:214: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callData" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp:86: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:50: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorAgent.cpp:62: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:74: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 84 in 223 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brent Fulgham

Comment 34 2013-12-11 13:30:09 PST

Comment on attachment 218929 [details] [PATCH] For Bots 8 View in context: https://bugs.webkit.org/attachment.cgi?id=218929&action=review > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:299 > + <ClInclude Include="..\bindings\bindings/ScriptFunctionCall.cpp" /> > + <ClInclude Include="..\bindings\bindings/ScriptObject.cpp" /> > + <ClInclude Include="..\bindings\bindings/ScriptValue.cpp" /> I think these should be <ClInclude Include="..\bindings\Script...." />

Brent Fulgham

Comment 35 2013-12-11 14:03:23 PST

Created attachment 219001 [details] Patch

WebKit Commit Bot

Comment 36 2013-12-11 14:06:49 PST

Attachment 219001 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreCommon.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/copy-files.cmd', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp', u'Source/JavaScriptCore/bindings/ScriptFunctionCall.h', u'Source/JavaScriptCore/bindings/ScriptObject.cpp', u'Source/JavaScriptCore/bindings/ScriptObject.h', u'Source/JavaScriptCore/bindings/ScriptValue.cpp', u'Source/JavaScriptCore/bindings/ScriptValue.h', u'Source/JavaScriptCore/inspector/InspectorAgentBase.h', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.h', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h', u'Source/JavaScriptCore/inspector/InspectorTypeBuilder.h', u'Source/JavaScriptCore/inspector/InspectorValues.cpp', u'Source/JavaScriptCore/inspector/InspectorValues.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/bindings/ScriptFunctionCall.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptObject.h', u'Source/WebCore/ForwardingHeaders/bindings/ScriptValue.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentBase.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentRegistry.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorTypeBuilder.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorValues.h', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBAny.cpp', u'Source/WebCore/Modules/indexeddb/IDBAny.h', u'Source/WebCore/Modules/indexeddb/IDBCursor.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursor.h', u'Source/WebCore/Modules/indexeddb/IDBFactory.cpp', u'Source/WebCore/Modules/indexeddb/IDBFactory.h', u'Source/WebCore/Modules/indexeddb/IDBIndex.cpp', u'Source/WebCore/Modules/indexeddb/IDBIndex.h', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp', u'Source/WebCore/Modules/indexeddb/IDBKeyRange.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.h', u'Source/WebCore/Modules/indexeddb/IDBRequest.cpp', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/mediastream/CapabilityRange.cpp', u'Source/WebCore/Modules/mediastream/CapabilityRange.h', u'Source/WebCore/Modules/mediastream/MediaTrackConstraint.h', u'Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.cpp', u'Source/WebCore/Modules/plugins/QuickTimePluginReplacement.h', u'Source/WebCore/UseJSC.cmake', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/Dictionary.h', u'Source/WebCore/bindings/js/IDBBindingUtilities.cpp', u'Source/WebCore/bindings/js/IDBBindingUtilities.h', u'Source/WebCore/bindings/js/JSBindingsAllInOne.cpp', u'Source/WebCore/bindings/js/JSDictionary.cpp', u'Source/WebCore/bindings/js/JSDictionary.h', u'Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptManager.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.h', u'Source/WebCore/bindings/js/JSMessageEventCustom.cpp', u'Source/WebCore/bindings/js/ScheduledAction.cpp', u'Source/WebCore/bindings/js/ScriptCallStackFactory.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptController.h', u'Source/WebCore/bindings/js/ScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptDebugServer.h', u'Source/WebCore/bindings/js/ScriptFunctionCall.cpp', u'Source/WebCore/bindings/js/ScriptFunctionCall.h', u'Source/WebCore/bindings/js/ScriptGlobalObject.cpp', u'Source/WebCore/bindings/js/ScriptGlobalObject.h', u'Source/WebCore/bindings/js/ScriptObject.cpp', u'Source/WebCore/bindings/js/ScriptObject.h', u'Source/WebCore/bindings/js/ScriptProfile.cpp', u'Source/WebCore/bindings/js/ScriptProfile.h', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.h', u'Source/WebCore/bindings/js/ScriptState.h', u'Source/WebCore/bindings/js/ScriptValue.cpp', u'Source/WebCore/bindings/js/ScriptValue.h', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.h', u'Source/WebCore/bindings/js/WorkerScriptController.cpp', u'Source/WebCore/bindings/js/WorkerScriptController.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp', u'Source/WebCore/dom/CustomEvent.cpp', u'Source/WebCore/dom/CustomEvent.h', u'Source/WebCore/dom/MessageEvent.cpp', u'Source/WebCore/dom/MessageEvent.h', u'Source/WebCore/dom/PopStateEvent.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/CodeGeneratorInspector.py', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ConsoleMessage.h', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/ContentSearchUtils.h', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScript.h', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.cpp', u'Source/WebCore/inspector/InjectedScriptCanvasModule.h', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAgentRegistry.cpp', u'Source/WebCore/inspector/InspectorAgentRegistry.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/inspector/InspectorBaseAgent.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.h', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.h', u'Source/WebCore/inspector/InspectorCanvasInstrumentation.h', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.h', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.h', u'Source/WebCore/inspector/InspectorDOMStorageAgent.cpp', u'Source/WebCore/inspector/InspectorDOMStorageAgent.h', u'Source/WebCore/inspector/InspectorDatabaseAgent.cpp', u'Source/WebCore/inspector/InspectorDatabaseAgent.h', u'Source/WebCore/inspector/InspectorDatabaseResource.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.h', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorIndexedDBAgent.h', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInputAgent.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.h', u'Source/WebCore/inspector/InspectorMemoryAgent.cpp', u'Source/WebCore/inspector/InspectorMemoryAgent.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.cpp', u'Source/WebCore/inspector/InspectorResourceAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.cpp', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.h', u'Source/WebCore/inspector/InspectorStyleTextEditor.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.h', u'Source/WebCore/inspector/InspectorValues.cpp', u'Source/WebCore/inspector/InspectorValues.h', u'Source/WebCore/inspector/InspectorWebAgentBase.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.h', u'Source/WebCore/inspector/ScriptArguments.cpp', u'Source/WebCore/inspector/ScriptArguments.h', u'Source/WebCore/inspector/ScriptCallFrame.cpp', u'Source/WebCore/inspector/ScriptCallFrame.h', u'Source/WebCore/inspector/ScriptCallStack.cpp', u'Source/WebCore/inspector/ScriptCallStack.h', u'Source/WebCore/inspector/ScriptDebugListener.h', u'Source/WebCore/inspector/TimelineRecordFactory.cpp', u'Source/WebCore/inspector/TimelineRecordFactory.h', u'Source/WebCore/inspector/WorkerConsoleAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/testing/Internals.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerThread.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebFrame.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/inspector/CodeGeneratorInspector.py:265: [RawTypes.BaseType.get_raw_validator_call_text] Class 'BaseType' has no 'get_validate_method_params' member [pylint/E1101] [5] ERROR: Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.h:44: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:117: The parameter name "pseudoIdMatches" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:75: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:46: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:49: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:51: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:54: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:55: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:56: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:92: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:388: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:426: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:429: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:472: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:473: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:510: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:611: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:615: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:701: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:709: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorTimelineAgent.cpp:585: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptValue.h:51: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:215: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:97: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.cpp:51: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:50: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:73: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:87: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:110: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:111: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:130: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:131: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/inspector/InspectorProfilerAgent.cpp:124: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InjectedScript.h:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InjectedScript.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:47: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:56: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.h:75: The parameter name "handler" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorWorkerAgent.cpp:112: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:561: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCSSAgent.cpp:620: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:72: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:81: cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:85: ExactlyInt::cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:88: ExactlyInt::cast_to_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/inspector/InspectorTypeBuilder.h:88: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:40: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/JavaScriptCore/bindings/ScriptObject.cpp:46: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorCanvasAgent.cpp:67: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorMemoryAgent.cpp:90: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:54: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:356: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorInputAgent.cpp:57: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorConsoleAgent.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/inspector/InspectorResourceAgent.cpp:654: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:66: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebCore/inspector/InspectorDatabaseAgent.cpp:214: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSMainThreadExecState.h:111: The parameter name "callData" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp:86: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:50: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorAgent.cpp:62: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:74: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 84 in 225 files If any of these errors are false positives, please file a bug against check-webkit-style.

Joseph Pecoraro

Comment 37 2013-12-11 14:23:15 PST

Created attachment 219002 [details] [DIFF] Windows Fixes Ugh, leave it to webkit-patch to obsolete and remove all the review flags from previous attachments... Attaching just what the Windows diffs were. In any case, I'm going to go ahead and land the working combined patch in one go instead of in pieces. It will be too much work at this point to separate them again into 4 distinct patches.

Joseph Pecoraro

Comment 38 2013-12-11 14:38:12 PST

Landed r160457 <http://trac.webkit.org/changeset/160457>.

Csaba Osztrogonác

Comment 39 2014-02-13 03:48:14 PST

Comment on attachment 219001 [details] Patch Cleared review? from attachment 219001 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Radar WebKit Bug Importer

Comment 40 2014-02-13 03:48:34 PST

<rdar://problem/16057894>

Note You need to log in before you can comment on or make changes to this bug.