Bug 125309

Summary:

[Win] Avoid copying compiled-in resources to DSTROOT

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

bfulgham, jer.noble

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

125249

Bug Blocks:

Attachments:

Description	Flags
Patch	jer.noble: review+

Brent Fulgham

Reported 2013-12-05 10:57:18 PST

We don't need to include the WebKit.rc file, or the various PNG's that are compiled into the DLL when we build the installer. It turns out that ONLY the Info.plist needs to be copied from the source WebKit.resource directory to the DSTROOT's resource directory. All the other contents are compiled into the WebKit.dll.

Attachments
Patch (1.45 KB, patch) 2013-12-05 12:24 PST, Brent Fulgham	jer.noble: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2013-12-05 12:24:43 PST

Created attachment 218531 [details] Patch

Jer Noble

Comment 2 2013-12-05 12:38:25 PST

Comment on attachment 218531 [details] Patch r=me

Brent Fulgham

Comment 3 2013-12-05 12:39:25 PST

Committed r160188: <http://trac.webkit.org/changeset/160188>

Note You need to log in before you can comment on or make changes to this bug.