AX: WK2: Safari extension installation hangs Safari and VoiceOver

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

1-open safari and search for safari extension (any so far)
2-once downloaded, go to finder and open the ext file.

* EXPECTED RESULTS:
extension to install with the dialog in safari asking to confirm installation of the extension.

* ACTUAL RESULTS:
safari and voice over freeze. Difficult to get out

[chris fleizach]

<rdar://problem/15594097>

[chris fleizach]

Created attachment 218524 [details]
patch

[Alexey Proskuryakov]

This is super scary. With this patch, dispatchDecidePolicyForResponse will have entirely different behavior when accessibility is enabled.

[Alexey Proskuryakov]

If you can prove that it is safe to spin run loop here, I suggest making it unconditionally.

Otherwise, we might need a deeper change to ho extensions are installed.

[chris fleizach]

(In reply to comment #4)
> If you can prove that it is safe to spin run loop here, I suggest making it unconditionally.
> 
> Otherwise, we might need a deeper change to ho extensions are installed.

This seems not that much different from javascript alerts where we do

    unsigned syncSendFlags = (WebCore::AXObjectCache::accessibilityEnabled()) ? CoreIPC::SpinRunLoopWhileWaitingForReply : 0;

    WebProcess::shared().parentProcessConnection()->sendSync(Messages::WebPageProxy::RunJavaScriptAlert(webFrame->frameID(), alertText), Messages::WebPageProxy::RunJavaScriptAlert::Reply(), m_page->pageID(), CoreIPC::Connection::NoTimeout, syncSendFlags);

That code has been in for 2 years, and we do have one case where it has proven to be unsafe (https://bugs.webkit.org/show_bug.cgi?id=123828) which I am very close to having a fix for.

[Alexey Proskuryakov]

Should we make it unconditional in that case?

Anders and Brady are really the ones who should make the call on whether it's acceptable design to spin the run loop here.

[chris fleizach]

(In reply to comment #6)
> Should we make it unconditional in that case?
> 

Not sure. I think Anders and Darin helped me resolve the javascript case in the past, so (echoing you) they'll probably be able to speak to that more.

Thanks

> Anders and Brady are really the ones who should make the call on whether it's acceptable design to spin the run loop here.

[Anders Carlsson]

Comment on attachment 218524 [details]
patch

I think this looks good.

[WebKit Commit Bot]

Comment on attachment 218524 [details]
patch

Clearing flags on attachment: 218524

Committed r160197: <http://trac.webkit.org/changeset/160197>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.