|Summary:||AX: WK2: Safari extension installation hangs Safari and VoiceOver|
|Product:||WebKit||Reporter:||chris fleizach <cfleizach>|
|Component:||Accessibility||Assignee:||chris fleizach <cfleizach>|
|Severity:||Normal||CC:||andersca, ap, beidson, commit-queue, jberlin, webkit-bug-importer|
|Version:||528+ (Nightly build)|
Description chris fleizach 2013-12-05 10:42:02 PST
Comment 1 chris fleizach 2013-12-05 10:42:11 PST
Comment 2 chris fleizach 2013-12-05 10:43:32 PST
Created attachment 218524 [details] patch
Comment 3 Alexey Proskuryakov 2013-12-05 11:02:41 PST
This is super scary. With this patch, dispatchDecidePolicyForResponse will have entirely different behavior when accessibility is enabled.
Comment 4 Alexey Proskuryakov 2013-12-05 11:04:38 PST
If you can prove that it is safe to spin run loop here, I suggest making it unconditionally. Otherwise, we might need a deeper change to ho extensions are installed.
Comment 5 chris fleizach 2013-12-05 11:23:24 PST
Comment 6 Alexey Proskuryakov 2013-12-05 11:28:13 PST
Should we make it unconditional in that case? Anders and Brady are really the ones who should make the call on whether it's acceptable design to spin the run loop here.
Comment 7 chris fleizach 2013-12-05 11:30:45 PST
Comment 8 Anders Carlsson 2013-12-05 15:00:02 PST
Comment on attachment 218524 [details] patch I think this looks good.
Comment 9 WebKit Commit Bot 2013-12-05 15:30:18 PST
Comment on attachment 218524 [details] patch Clearing flags on attachment: 218524 Committed r160197: <http://trac.webkit.org/changeset/160197>
Comment 10 WebKit Commit Bot 2013-12-05 15:30:21 PST
All reviewed patches have been landed. Closing bug.