Bug 125302

Summary: [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: BindingsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, pnormand
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch pnormand: review+

Carlos Garcia Campos
Reported 2013-12-05 05:21:09 PST
The following API are missing documentation: WEBKIT_API WEBKIT_DEPRECATED WEBKIT_DEPRECATED_FOR Those are macros that shouldn't be documented, but they should be added to the -sections.txt as private API file to avoid the gtk-doc warnings.
Attachments
Patch (1.59 KB, patch)
2013-12-05 05:23 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (1.54 KB, patch)
2013-12-05 05:31 PST, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-12-05 05:23:17 PST
Created attachment 218506 [details] Patch
Philippe Normand
Comment 2 2013-12-05 05:27:22 PST
Comment on attachment 218506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218506&action=review > Tools/gtk/generate-webkitdom-doc-files:193 > + sys.stdout.write('<FILE>webkitdeomdefines</FILE>\n<TITLE>WebKitDOMDefines</TITLE>\n') deom ? :)
Carlos Garcia Campos
Comment 3 2013-12-05 05:29:46 PST
(In reply to comment #2) > (From update of attachment 218506 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218506&action=review > > > Tools/gtk/generate-webkitdom-doc-files:193 > > + sys.stdout.write('<FILE>webkitdeomdefines</FILE>\n<TITLE>WebKitDOMDefines</TITLE>\n') > > deom ? :) Oops, it doesn't really matter actually, but good catch, will update the patch :-)
Carlos Garcia Campos
Comment 4 2013-12-05 05:31:58 PST
Created attachment 218507 [details] Updated patch Fixed typo
Carlos Garcia Campos
Comment 5 2013-12-05 06:30:05 PST
Committed r160173: <http://trac.webkit.org/changeset/160173>
Note You need to log in before you can comment on or make changes to this bug.