Bug 125281
| Summary: | Fix flakiness in cross-fade tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, bdakin, eric.carlson, simon.fraser, thorton |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/e8d30a68585a67f08f5bb184c44e0df6669e932f
if the fix is applicable.
A handful of cross-fade tests were flaky failures due to running before the images were loaded. Coincidentally, this problem was exacerbated by the switch to using the pause API as opposed to rAF since it allowed the tests to run immediately.
Updating the tests to wait for images to be loaded before running.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Horton
Oh that would explain so much.
Alexey Proskuryakov
Looking at flakiness dashboard for "cross-fade", I don't see much flakiness per se, although these tests are somewhat unwell indeed.
Maybe a good idea to merge anyway?
Ryosuke Niwa
(In reply to comment #2)
> Looking at flakiness dashboard for "cross-fade", I don't see much flakiness per se, although these tests are somewhat unwell indeed.
Looks like some of these might be marked flaky or skipped altogether?