Summary: | [Win] Exiting from Media Full Screen mode via 'escape' key does not work properly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Media | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, jer.noble, jonlee | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brent Fulgham
2013-12-04 17:58:16 PST
Created attachment 218520 [details]
Patch
Comment on attachment 218520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218520&action=review r=me, with nit. > Source/WebKit/win/WebView.cpp:6958 > - m_fullScreenElement->document().webkitWillExitFullScreenForElement(m_fullScreenElement.get()); > + m_fullScreenElement->document().webkitExitFullscreen(); This should probably use webkitCancelFullScreen(), which will pop the entire full screen element stack. Committed r160184: <http://trac.webkit.org/changeset/160184> |