Bug 125267

Summary: Add a WeakObjCPtr class
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Anders Carlsson
Reported 2013-12-04 17:02:07 PST
Add a WeakObjCPtr class
Attachments
Patch (14.69 KB, patch)
2013-12-04 17:04 PST, Anders Carlsson 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-12-04 17:04:09 PST
Created attachment 218472 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-04 17:05:41 PST
Attachment 218472 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/WeakObjCPtr.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj', u'Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm', '--commit-queue']" exit_code: 1 ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:32: Missing spaces around / [whitespace/operators] [3] ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:36: objc_loadWeakRetained is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:37: objc_initWeak is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:38: objc_destroyWeak is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 4 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2013-12-04 17:08:00 PST
Comment on attachment 218472 [details] Patch r=me
Anders Carlsson
Comment 4 2013-12-04 17:23:24 PST
Committed r160146: <http://trac.webkit.org/changeset/160146>
Note You need to log in before you can comment on or make changes to this bug.