Bug 125267

Summary:

Add a WeakObjCPtr class

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+

Description Anders Carlsson 2013-12-04 17:02:07 PST

Add a WeakObjCPtr class

Comment 1 Anders Carlsson 2013-12-04 17:04:09 PST

Created attachment 218472 [details]
Patch

Comment 2 WebKit Commit Bot 2013-12-04 17:05:41 PST

Attachment 218472 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/WeakObjCPtr.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj', u'Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:32:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:36:  objc_loadWeakRetained is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:37:  objc_initWeak is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:38:  objc_destroyWeak is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Geoffrey Garen 2013-12-04 17:08:00 PST

Comment on attachment 218472 [details]
Patch

r=me

Comment 4 Anders Carlsson 2013-12-04 17:23:24 PST

Committed r160146: <http://trac.webkit.org/changeset/160146>