Bug 125254

Summary:

check-webkit-style: false positive warning for indentation of #ifdef code

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gbalogh.u-szeged, glenn, llango.u-szeged, tgergely.u-szeged

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Daniel Bates 2013-12-04 14:19:53 PST

When processing the attachment #218443 [details] (bug #125239), check-webkit-style emitted the following false positives:

ERROR: Source/WebCore/rendering/RenderLayer.cpp:185:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayer.cpp:2725:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayer.cpp:2725:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderMenuList.cpp:81:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:432:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:433:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:435:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:437:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:446:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:447:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderFileUploadControl.cpp:106:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderFileUploadControl.cpp:107:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]

Notice that all of these errors are with respect to code that is within a #ifdef/#else-block.

Comment 1 Gergő Balogh 2013-12-05 02:08:08 PST

The commit 251bfc338f7f629cc2e3646bd0af707314bddb04 fix most of these issues. I will check the rest of them.

Remaining:
ERROR: Source/WebCore/rendering/RenderLayer.cpp:180:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayer.cpp:185:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayer.cpp:196:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayer.cpp:199:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderLayer.cpp:3640:  Wrong number of spaces before statement. (expected: 32)  [whitespace/indent] [4]

Checked on:
commit a53256abaefeacb27f386aa7fd739b81636bc334

Comment 2 Gergő Balogh 2013-12-06 01:54:39 PST

Created attachment 218578 [details]
patch

Comment 3 WebKit Commit Bot 2013-12-06 10:52:18 PST

Comment on attachment 218578 [details]
patch

Clearing flags on attachment: 218578

Committed r160229: <http://trac.webkit.org/changeset/160229>

Comment 4 WebKit Commit Bot 2013-12-06 10:55:55 PST

All reviewed patches have been landed.  Closing bug.