Bug 125246

Summary: check-webkit-style detected some ternary statements as initialization lists
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, burg, commit-queue, darin, dbates, galpeter, glenn, llango.u-szeged, rniwa, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2013-12-04 13:04:20 PST
check-webkit-style detected some turnary statements as initialization lists
Attachments
Patch (2.42 KB, patch)
2013-12-04 13:06 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (2.99 KB, patch)
2013-12-04 13:24 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2013-12-04 13:06:17 PST
Created attachment 218432 [details] Patch
Dean Jackson
Comment 2 2013-12-04 13:11:59 PST
Comment on attachment 218432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218432&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:1989 > + if search(r'^(?P<indentation>\s*)((explicit )?[^\s]+\(.*\)\s?\:|^\s*\:).*[^;]*$', line): Should this be explicit\s+ ? > Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4986 > + self.assert_lint('o = foo(b ? bar() : baz());', '') Should you have a test with "explicit" too?
Myles C. Maxfield
Comment 3 2013-12-04 13:24:25 PST
Created attachment 218437 [details] Patch
WebKit Commit Bot
Comment 4 2013-12-04 14:13:40 PST
Comment on attachment 218437 [details] Patch Clearing flags on attachment: 218437 Committed r160124: <http://trac.webkit.org/changeset/160124>
WebKit Commit Bot
Comment 5 2013-12-04 14:13:42 PST
All reviewed patches have been landed. Closing bug.
László Langó
Comment 6 2013-12-05 00:37:34 PST
Nice, thanks for the fix.
Note You need to log in before you can comment on or make changes to this bug.