| Summary: | Replace USE(SECURITY_FRAMEWORK) with finer-grained defines | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||
| Component: | WebKit2 | Assignee: | mitz | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cmarcelo, commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
mitz
2013-12-04 12:26:27 PST
Created attachment 218428 [details]
Remove USE(SECURITY_FRAMEWORK) and add HAVE(SEC_IDENTITY), HAVE(SEC_KEYCHAIN), and ENABLE(SEC_ITEM_SHIM)
Comment on attachment 218428 [details] Remove USE(SECURITY_FRAMEWORK) and add HAVE(SEC_IDENTITY), HAVE(SEC_KEYCHAIN), and ENABLE(SEC_ITEM_SHIM) View in context: https://bugs.webkit.org/attachment.cgi?id=218428&action=review > Source/WebKit2/config.h:102 > +#ifndef HAVE_SEC_IDENTITY > +#if PLATFORM(MAC) && !PLATFORM(IOS) > +#define HAVE_SEC_IDENTITY 1 > +#endif > +#endif > + > +#ifndef HAVE_SEC_KEYCHAIN > +#if PLATFORM(MAC) && !PLATFORM(IOS) > +#define HAVE_SEC_KEYCHAIN 1 > +#endif > +#endif I would move these to Platform.h, as they could apply to any of the projects. The Shim is WebKit2 specific, so can stay here. (In reply to comment #2) > (From update of attachment 218428 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218428&action=review > > > Source/WebKit2/config.h:102 > > +#ifndef HAVE_SEC_IDENTITY > > +#if PLATFORM(MAC) && !PLATFORM(IOS) > > +#define HAVE_SEC_IDENTITY 1 > > +#endif > > +#endif > > + > > +#ifndef HAVE_SEC_KEYCHAIN > > +#if PLATFORM(MAC) && !PLATFORM(IOS) > > +#define HAVE_SEC_KEYCHAIN 1 > > +#endif > > +#endif > > I would move these to Platform.h, as they could apply to any of the projects. The Shim is WebKit2 specific, so can stay here. Will do. Thank you! Committed <http://trac.webkit.org/r160117>. |