Bug 12521

Summary:

CSS3: Support values 'start' and 'end' for text-align property

Product:

WebKit

Reporter:

Nicholas Shanks <nickshanks>

Component:

Text

Assignee:

Nicholas Shanks <nickshanks>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch	none
replace case a...b with enumerated cases per hyatt's request	none
removed BOM and tabs from test case	darin: review-
attempt number 4	hyatt: review-
now all fixed and stuff	hyatt: review+
even better fixing after hyatt's comments (ready to land)	eric: review+

Nicholas Shanks

Reported 2007-01-31 20:36:43 PST

Patch attached

Attachments
patch (4.50 KB, patch) 2007-01-31 20:37 PST, Nicholas Shanks	no flags	Details Formatted Diff Diff
replace case a...b with enumerated cases per hyatt's request (4.73 KB, patch) 2007-01-31 20:57 PST, Nicholas Shanks	no flags	Details Formatted Diff Diff
removed BOM and tabs from test case (4.76 KB, patch) 2007-02-01 07:22 PST, Nicholas Shanks	darin: review-	Details Formatted Diff Diff
attempt number 4 (4.62 KB, patch) 2007-02-01 13:56 PST, Nicholas Shanks	hyatt: review-	Details Formatted Diff Diff
now all fixed and stuff (16.51 KB, patch) 2007-10-01 13:26 PDT, Eric Seidel (no email)	hyatt: review+	Details Formatted Diff Diff
even better fixing after hyatt's comments (ready to land) (16.51 KB, patch) 2007-10-01 13:44 PDT, Eric Seidel (no email)	eric: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Nicholas Shanks

Comment 1 2007-01-31 20:37:46 PST

Created attachment 12844 [details] patch

Dave Hyatt

Comment 2 2007-01-31 20:47:33 PST

Comment on attachment 12844 [details] patch You can't check the style while resolution is in progress. The direction has not been determined yet.

Dave Hyatt

Comment 3 2007-01-31 20:48:23 PST

Comment on attachment 12844 [details] patch Oh, oops. Never mind. I forgot that I hacked direction to be one of the properties examined early.

Nicholas Shanks

Comment 4 2007-01-31 20:57:56 PST

Created attachment 12846 [details] replace case a...b with enumerated cases per hyatt's request

Nicholas Shanks

Comment 5 2007-02-01 07:22:08 PST

Created attachment 12855 [details] removed BOM and tabs from test case

Darin Adler

Comment 6 2007-02-01 07:42:21 PST

Comment on attachment 12855 [details] removed BOM and tabs from test case The test contains a call to dumpAsText -- I don't understand why because I don't see how a plain-text dump would demonstrate whether the bug is fixed or not. Further, the patch contains a render tree dump in the expected.txt, not plain text. There's no pixel test result: expected.checksum or expected.png. If this is a plain-text test, then it needs a plain-text result. If not, then it should not have code saying dumpAsText and it needs a pixel result.

Nicholas Shanks

Comment 7 2007-02-01 13:56:59 PST

Created attachment 12860 [details] attempt number 4 you'll have to blame bdash: my original patch didn't have that script but he told me to put it in there! I don't know what it's for.

Eric Seidel (no email)

Comment 8 2007-10-01 09:25:45 PDT

Comment on attachment 12860 [details] attempt number 4 I didn't see any serious complaints in the bug about the previous patch. I believe this one was meant to be marked for review. The patch looks fine to me. But lets get a second opinion.

Dave Hyatt

Comment 9 2007-10-01 12:48:32 PDT

Comment on attachment 12860 [details] attempt number 4 Change the switch statement to just be an if/else block. if (start) ... else if (end) ... and then do the assignment of the property.

Eric Seidel (no email)

Comment 10 2007-10-01 13:26:55 PDT

Created attachment 16488 [details] now all fixed and stuff

Dave Hyatt

Comment 11 2007-10-01 13:28:40 PDT

Comment on attachment 16488 [details] now all fixed and stuff r=me

Eric Seidel (no email)

Comment 12 2007-10-01 13:44:37 PDT

Created attachment 16489 [details] even better fixing after hyatt's comments (ready to land)

Eric Seidel (no email)

Comment 13 2007-10-01 13:45:02 PDT

Comment on attachment 16489 [details] even better fixing after hyatt's comments (ready to land) marking this as reviewed (hyatt did so already), as it's ready to land.

Eric Seidel (no email)

Comment 14 2007-10-02 14:41:54 PDT

Landed on feature-branch as r25939.

Note You need to log in before you can comment on or make changes to this bug.