Bug 125205

Summary:

Fold constant typed arrays

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, rakuco, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

124630

Bug Blocks:

125252

Attachments:

Description	Flags
it begins	none
it does some of the things	none
the patch	oliver: review+

Filip Pizlo

Reported 2013-12-03 18:52:45 PST

Patch forthcoming, after https://bugs.webkit.org/show_bug.cgi?id=124630 lands.

Attachments
it begins (7.07 KB, patch) 2013-12-03 20:09 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
it does some of the things (25.10 KB, patch) 2013-12-04 12:43 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (41.97 KB, patch) 2013-12-04 14:48 PST, Filip Pizlo	oliver: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2013-12-03 20:09:36 PST

Created attachment 218377 [details] it begins

Filip Pizlo

Comment 2 2013-12-04 12:43:21 PST

Created attachment 218430 [details] it does some of the things

Filip Pizlo

Comment 3 2013-12-04 14:48:27 PST

Created attachment 218457 [details] the patch

WebKit Commit Bot

Comment 4 2013-12-04 14:51:31 PST

Attachment 218457 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/js/regress/fixed-typed-array-storage-expected.txt', u'LayoutTests/js/regress/fixed-typed-array-storage-var-index-expected.txt', u'LayoutTests/js/regress/fixed-typed-array-storage-var-index.html', u'LayoutTests/js/regress/fixed-typed-array-storage.html', u'LayoutTests/js/regress/script-tests/fixed-typed-array-storage-var-index.js', u'LayoutTests/js/regress/script-tests/fixed-typed-array-storage.js', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/dfg/DFGDesiredWatchpoints.cpp', u'Source/JavaScriptCore/dfg/DFGDesiredWatchpoints.h', u'Source/JavaScriptCore/dfg/DFGGraph.cpp', u'Source/JavaScriptCore/dfg/DFGGraph.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGWatchpointCollectionPhase.cpp', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/runtime/ArrayBuffer.cpp', u'Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.cpp', u'Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.h', u'Source/JavaScriptCore/runtime/VM.cpp', u'Source/JavaScriptCore/runtime/VM.h', '--commit-queue']" exit_code: 1 ERROR: Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.cpp:39: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Hahnenberg

Comment 5 2013-12-04 15:10:45 PST

Comment on attachment 218457 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=218457&action=review r=me too > Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.cpp:49 > +ArrayBufferNeuteringWatchpoint::~ArrayBufferNeuteringWatchpoint() { } > + > +void ArrayBufferNeuteringWatchpoint::finishCreation(VM& vm) > +{ > + Base::finishCreation(vm); > +} Not necessary. > Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.h:42 > + ~ArrayBufferNeuteringWatchpoint(); > + > + void finishCreation(VM&); Ditto.

Filip Pizlo

Comment 6 2013-12-04 18:02:58 PST

Landed in http://trac.webkit.org/changeset/160150

Note You need to log in before you can comment on or make changes to this bug.