Bug 125140

Summary: Debug build fix : Add '<algorithm>' for 'std::is_sorted' after r159965.
Product: WebKit Reporter: Seokju Kwon <seokju>
Component: WebKit2Assignee: Seokju Kwon <seokju>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 125104    
Attachments:
Description Flags
Patch none

Seokju Kwon
Reported 2013-12-03 01:54:20 PST
WebKit/Source/WebKit2/Shared/APIClient.h:64:16: error: ‘is_sorted’ is not a member of ‘std’ ASSERT(std::is_sorted(interfaceSizes.begin(), interfaceSizes.end())); See : http://www.cplusplus.com/reference/algorithm/is_sorted/
Attachments
Patch (1.11 KB, patch)
2013-12-03 01:56 PST, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Seokju Kwon
Comment 1 2013-12-03 01:56:50 PST
Created attachment 218278 [details] Patch
Seokju Kwon
Comment 2 2013-12-03 01:57:14 PST
CC'ing andersca
Seokju Kwon
Comment 3 2013-12-03 01:59:37 PST
@andersca Could you please review it?
Csaba Osztrogonác
Comment 4 2013-12-03 06:33:54 PST
Comment on attachment 218278 [details] Patch It is a trivial buildfix, we don't need WK2 owner review.
WebKit Commit Bot
Comment 5 2013-12-03 06:59:18 PST
Comment on attachment 218278 [details] Patch Clearing flags on attachment: 218278 Committed r160002: <http://trac.webkit.org/changeset/160002>
WebKit Commit Bot
Comment 6 2013-12-03 06:59:19 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 7 2013-12-03 09:46:41 PST
It would be better to include the header unconditionally. A conditional include: - takes more space on screen, so it's harder to read the code; - makes release and debug builds more different, so issues like this will be more likely to occur in the future.
Note You need to log in before you can comment on or make changes to this bug.