Bug 125140

Summary: Debug build fix : Add '<algorithm>' for 'std::is_sorted' after r159965.
Product: WebKit Reporter: Seokju Kwon <seokju>
Component: WebKit2Assignee: Seokju Kwon <seokju>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 125104    
Attachments:
Description Flags
Patch none

Description Seokju Kwon 2013-12-03 01:54:20 PST
WebKit/Source/WebKit2/Shared/APIClient.h:64:16: error: ‘is_sorted’ is not a member of ‘std’
         ASSERT(std::is_sorted(interfaceSizes.begin(), interfaceSizes.end()));

See : http://www.cplusplus.com/reference/algorithm/is_sorted/
Comment 1 Seokju Kwon 2013-12-03 01:56:50 PST
Created attachment 218278 [details]
Patch
Comment 2 Seokju Kwon 2013-12-03 01:57:14 PST
CC'ing andersca
Comment 3 Seokju Kwon 2013-12-03 01:59:37 PST
@andersca
Could you please review it?
Comment 4 Csaba Osztrogonác 2013-12-03 06:33:54 PST
Comment on attachment 218278 [details]
Patch

It is a trivial buildfix, we don't need WK2 owner review.
Comment 5 WebKit Commit Bot 2013-12-03 06:59:18 PST
Comment on attachment 218278 [details]
Patch

Clearing flags on attachment: 218278

Committed r160002: <http://trac.webkit.org/changeset/160002>
Comment 6 WebKit Commit Bot 2013-12-03 06:59:19 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Alexey Proskuryakov 2013-12-03 09:46:41 PST
It would be better to include the header unconditionally. A conditional include:

- takes more space on screen, so it's harder to read the code;
- makes release and debug builds more different, so issues like this will be more likely to occur in the future.