Summary: | [Mac] Modernize the WebKit API headers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||||
Component: | WebKit API | Assignee: | Mark Rowe (bdash) <mrowe> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mark Rowe (bdash)
2013-12-03 01:40:54 PST
Created attachment 218276 [details]
Patch
Attachment 218276 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/DOM/WebDOMOperations.h', u'Source/WebKit/mac/History/WebBackForwardList.h', u'Source/WebKit/mac/History/WebHistory.h', u'Source/WebKit/mac/History/WebHistoryItem.h', u'Source/WebKit/mac/History/WebHistoryItem.mm', u'Source/WebKit/mac/Plugins/WebPlugin.h', u'Source/WebKit/mac/Plugins/WebPluginContainer.h', u'Source/WebKit/mac/WebView/WebArchive.h', u'Source/WebKit/mac/WebView/WebArchive.mm', u'Source/WebKit/mac/WebView/WebDataSource.h', u'Source/WebKit/mac/WebView/WebDataSource.mm', u'Source/WebKit/mac/WebView/WebEditingDelegate.h', u'Source/WebKit/mac/WebView/WebFrame.h', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.h', u'Source/WebKit/mac/WebView/WebPolicyDelegate.h', u'Source/WebKit/mac/WebView/WebPreferences.h', u'Source/WebKit/mac/WebView/WebPreferences.mm', u'Source/WebKit/mac/WebView/WebResource.h', u'Source/WebKit/mac/WebView/WebResource.mm', u'Source/WebKit/mac/WebView/WebUIDelegate.h', u'Source/WebKit/mac/WebView/WebView.h', u'Source/WebKit/mac/WebView/WebView.mm', u'Tools/ChangeLog', u'Tools/DumpRenderTree/mac/TestRunnerMac.mm']" exit_code: 1
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:170: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:175: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:185: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:436: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:569: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:572: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebDataSource.h:117: Missing spaces around = [whitespace/operators] [4]
Total errors found: 7 in 26 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 218277 [details]
Patch
The revised patch fixes a mistaken use of NS_ENUM when NS_OPTIONS is more appropriate. Attachment 218277 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/DOM/WebDOMOperations.h', u'Source/WebKit/mac/History/WebBackForwardList.h', u'Source/WebKit/mac/History/WebHistory.h', u'Source/WebKit/mac/History/WebHistoryItem.h', u'Source/WebKit/mac/History/WebHistoryItem.mm', u'Source/WebKit/mac/Plugins/WebPlugin.h', u'Source/WebKit/mac/Plugins/WebPluginContainer.h', u'Source/WebKit/mac/WebView/WebArchive.h', u'Source/WebKit/mac/WebView/WebArchive.mm', u'Source/WebKit/mac/WebView/WebDataSource.h', u'Source/WebKit/mac/WebView/WebDataSource.mm', u'Source/WebKit/mac/WebView/WebEditingDelegate.h', u'Source/WebKit/mac/WebView/WebFrame.h', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.h', u'Source/WebKit/mac/WebView/WebPolicyDelegate.h', u'Source/WebKit/mac/WebView/WebPreferences.h', u'Source/WebKit/mac/WebView/WebPreferences.mm', u'Source/WebKit/mac/WebView/WebResource.h', u'Source/WebKit/mac/WebView/WebResource.mm', u'Source/WebKit/mac/WebView/WebUIDelegate.h', u'Source/WebKit/mac/WebView/WebView.h', u'Source/WebKit/mac/WebView/WebView.mm', u'Tools/ChangeLog', u'Tools/DumpRenderTree/mac/TestRunnerMac.mm']" exit_code: 1
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:170: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:175: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:185: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:436: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:569: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:572: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebUIDelegate.h:84: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebUIDelegate.h:102: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebDataSource.h:117: Missing spaces around = [whitespace/operators] [4]
Total errors found: 9 in 26 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r160414: <http://trac.webkit.org/changeset/160414> |