Summary: | Make sure we satisfy uniform and varying packing restrictions | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||||||||
Component: | WebGL | Assignee: | Roger Fong <roger_fong> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, dino, kondapallykalyan, noam, rniwa, roger_fong | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Roger Fong
2013-12-02 17:43:46 PST
Created attachment 218249 [details]
Patch
Attachment 218249 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp', u'Source/WebCore/platform/graphics/ANGLEWebKitBridge.h']" exit_code: 1
ERROR: Source/WebCore/platform/graphics/ANGLEWebKitBridge.h:49: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/ANGLEWebKitBridge.h:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 218249 [details] Patch Attachment 218249 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/39748020 New failing tests: webgl/1.0.2/conformance/ogles/GL/build/build_009_to_016.html Created attachment 218255 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 218249 [details] Patch Attachment 218249 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/42408007 New failing tests: webgl/1.0.2/conformance/ogles/GL/build/build_009_to_016.html Created attachment 218258 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 218546 [details]
Patch
Attachment 218546 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/TestExpectations', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ShHandle.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp:77: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4]
ERROR: Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp:77: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Ignore the style errors, that code is part of ANGLE. Speaking of which, I'll need to upstream those changes. Comment on attachment 218546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218546&action=review r=me, but please fix the typo in the ChangeLog. > Source/ThirdParty/ANGLE/ChangeLog:10 > + Add a check to enforcePackingRestrictions to ensure we make sure packing restrictions for varyings are satsified as well. satsified -> satisfied Fixed and committed: http://trac.webkit.org/changeset/160199 |