Bug 125084 – Add support for WebCrypto RSA-OAEP

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

This is for encrypting small chunks of data (primarily other keys) with RSA.

[Alexey Proskuryakov]

Created attachment 218197 [details]
proposed patch

[WebKit Commit Bot]

Attachment 218197 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/crypto/subtle/rsa-oaep-key-manipulation-expected.txt', u'LayoutTests/crypto/subtle/rsa-oaep-key-manipulation.html', u'LayoutTests/crypto/subtle/rsa-oaep-plaintext-length-expected.txt', u'LayoutTests/crypto/subtle/rsa-oaep-plaintext-length.html', u'LayoutTests/crypto/subtle/rsa-oaep-wrap-unwrap-aes-expected.txt', u'LayoutTests/crypto/subtle/rsa-oaep-wrap-unwrap-aes.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp', u'Source/WebCore/bindings/js/JSCryptoKeySerializationJWK.cpp', u'Source/WebCore/crypto/CommonCryptoUtilities.cpp', u'Source/WebCore/crypto/CommonCryptoUtilities.h', u'Source/WebCore/crypto/CryptoAlgorithmParameters.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.h', u'Source/WebCore/crypto/mac/CryptoAlgorithmHMACMac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp', u'Source/WebCore/crypto/mac/CryptoKeyMac.cpp', u'Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp', u'Source/WebCore/crypto/parameters/CryptoAlgorithmRsaOaepParams.h']" exit_code: 1
Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:40:  CryptoAlgorithmRSA_OAEP::s_name is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:50:  CryptoAlgorithmRSA_OAEP::create is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:55:  CryptoAlgorithmRSA_OAEP::identifier is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:60:  CryptoAlgorithmRSA_OAEP::keyAlgorithmMatches is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:73:  CryptoAlgorithmRSA_OAEP::encrypt is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:85:  CryptoAlgorithmRSA_OAEP::decrypt is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:97:  CryptoAlgorithmRSA_OAEP::generateKey is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:108:  CryptoAlgorithmRSA_OAEP::importKey is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:38:  CryptoAlgorithmRSA_OAEP::platformEncrypt is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:59:  CryptoAlgorithmRSA_OAEP::platformDecrypt is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/crypto/CommonCryptoUtilities.h:34:  Missing spaces around /  [whitespace/operators] [3]
Source/WebCore/crypto/CommonCryptoUtilities.h:40:  Missing spaces around /  [whitespace/operators] [3]
Source/WebCore/crypto/CommonCryptoUtilities.h:47:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/crypto/CommonCryptoUtilities.h:48:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/crypto/CommonCryptoUtilities.h:49:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/crypto/CommonCryptoUtilities.h:50:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/crypto/CommonCryptoUtilities.h:51:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/crypto/CommonCryptoUtilities.h:56:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/crypto/CommonCryptoUtilities.h:57:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/crypto/CommonCryptoUtilities.h:62:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/crypto/CommonCryptoUtilities.h:63:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/crypto/CommonCryptoUtilities.h:68:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 23 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r159944>.

[Alexey Proskuryakov]

Build fix in <http://trac.webkit.org/r159949>.

[Alexey Proskuryakov]

More build fix in <http://trac.webkit.org/r159951>.