Bug 125072

Summary: Web Inspector: add a method to add padding around a WebInspector.Rect
Product: WebKit Reporter: Antoine Quint <graouts>
Component: Web InspectorAssignee: Antoine Quint <graouts>
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch none

Description Antoine Quint 2013-12-02 03:32:19 PST
We do the following in quite a few places in the code when computing the targetFrame for a popover:

    const padding = 2;
    bounds.origin.x -= padding;
    bounds.origin.y -= padding;
    bounds.size.width += padding * 2;
    bounds.size.height += padding * 2;

It sounds like we ought to add a method on WebInspector.Rect to add padding.
Comment 1 Antoine Quint 2013-12-02 03:35:24 PST
Created attachment 218158 [details]
Comment 2 Joseph Pecoraro 2013-12-02 10:11:23 PST
Comment on attachment 218158 [details]

Nice, r=me
Comment 3 WebKit Commit Bot 2013-12-02 11:53:10 PST
Comment on attachment 218158 [details]

Clearing flags on attachment: 218158

Committed r159946: <http://trac.webkit.org/changeset/159946>
Comment 4 WebKit Commit Bot 2013-12-02 11:53:12 PST
All reviewed patches have been landed.  Closing bug.