Bug 125072

Summary:

Web Inspector: add a method to add padding around a WebInspector.Rect

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Web Inspector

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Antoine Quint

Reported 2013-12-02 03:32:19 PST

We do the following in quite a few places in the code when computing the targetFrame for a popover: const padding = 2; bounds.origin.x -= padding; bounds.origin.y -= padding; bounds.size.width += padding * 2; bounds.size.height += padding * 2; It sounds like we ought to add a method on WebInspector.Rect to add padding.

Attachments
Patch (7.87 KB, patch) 2013-12-02 03:35 PST, Antoine Quint	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2013-12-02 03:35:24 PST

Created attachment 218158 [details] Patch

Joseph Pecoraro

Comment 2 2013-12-02 10:11:23 PST

Comment on attachment 218158 [details] Patch Nice, r=me

WebKit Commit Bot

Comment 3 2013-12-02 11:53:10 PST

Comment on attachment 218158 [details] Patch Clearing flags on attachment: 218158 Committed r159946: <http://trac.webkit.org/changeset/159946>

WebKit Commit Bot

Comment 4 2013-12-02 11:53:12 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.