Bug 12507
| Summary: | Hebrew form data can be uploaded with wrong encoding name (visual vs. logical) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> |
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, mitz |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
Darin Adler
<GMT25-Aug-2003 01:50:10GMT> Darin Adler:
The code that maps a QTextCodec back to an encoding name doesn't take the flags into account. It should. The effect of this is that you can end up with the name of a Hebrew visual encoding when you meant logical or vice versa.
<GMT25-Aug-2003 01:52:44GMT> Darin Adler:
The fix to this is relatively simple; just take the flags into account when doing the reverse mapping. An even better fix would be to change things so that we use the encoding name from the incoming side on the outgoing side; the QTextCodec could remember the name it was created with. Then we could remove the reverse mapping altogether.
I've attached a first cut at a patch.
<rdar://problem/3391826>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
TextEncoding now keeps the original charset name - is this issue still valid?
Darin Adler
(In reply to comment #1)
> TextEncoding now keeps the original charset name - is this issue still valid?
Probably not! Lets see if we can test it to be sure.
Darin Adler
OK, agreed that this is fixed.