Bug 125068

Summary: [GTK][WK2] WebKit2.GeolocationTransitionTo(High|Low)Accuracy unit tests are crashing the following test
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, clopez, commit-queue, mcatanzaro, Ms2ger, pnormand, svillar
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2013-12-02 02:07:42 PST
The following two unit tests are crashing the succeeding unit test: WebKit2.GeolocationTransitionToHighAccuracy WebKit2.GeolocationTransitionToLowAccuracy This is due to the tests using two separate contexts and relying on context-specific operations (in this case geolocation callbacks). This falters when using a shared WebProcess as the first context remains in use in the UIProcess when the second one should actually be in use.
Attachments
Patch (1.43 KB, patch)
2018-02-07 03:21 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Patch (1.51 KB, patch)
2018-02-07 07:22 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-12-02 02:10:24 PST
This would most likely be fixed by using multiple web processes, though I wasn't able to confirm that.
Carlos Alberto Lopez Perez
Comment 2 2014-04-16 08:51:03 PDT
I'm not longer able to reproduce this failure... I think we can unskip both tests WebKit2.GeolocationTransitionToHighAccuracy and WebKit2.GeolocationTransitionToLowAccuracy
Philippe Normand
Comment 3 2014-08-28 02:01:50 PDT
Let's do it then :) rs=me
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 4 2018-02-07 03:21:22 PST
Created attachment 333276 [details] Patch
WebKit Commit Bot
Comment 5 2018-02-07 06:08:10 PST
Comment on attachment 333276 [details] Patch Rejecting attachment 333276 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 333276, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: org/git/WebKit 4fe81b77d32..90acbb324bb master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 228221 = 4fe81b77d3235313658cc8aeb764650aecde86cf r228222 = 90acbb324bb0d6eea1913d8b5b029467c0522d21 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/6398248
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 6 2018-02-07 07:22:16 PST
Created attachment 333281 [details] Patch
WebKit Commit Bot
Comment 7 2018-02-07 08:09:27 PST
Comment on attachment 333281 [details] Patch Clearing flags on attachment: 333281 Committed r228225: <https://trac.webkit.org/changeset/228225>
WebKit Commit Bot
Comment 8 2018-02-07 08:09:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.