Bug 125065

Summary:

Fix EFL build with INPUT_TYPE_COLOR disabled

Product:

WebKit

Reporter:

Peter Molnar <pmolnar.u-szeged>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Peter Molnar

Reported 2013-12-02 01:02:37 PST

"using namespace WebCore;" is used in Source/WebKit2/UIProcess/API/efl/ewk_color_picker.cpp, because class Color is defined in WebCore namespace. But if ENABLE(INPUT_TYPE_COLOR) is false there is no WebCore namespace in Source/WebKit2/UIProcess/API/efl/ewk_color_picker.cpp and the build fails.

Attachments
Patch (1.17 KB, patch) 2013-12-02 01:03 PST, Peter Molnar	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Peter Molnar

Comment 1 2013-12-02 01:03:52 PST

Created attachment 218150 [details] Patch

Zoltan Herczeg

Comment 2 2013-12-03 04:39:10 PST

Comment on attachment 218150 [details] Patch r=me

WebKit Commit Bot

Comment 3 2013-12-03 04:41:39 PST

Comment on attachment 218150 [details] Patch Clearing flags on attachment: 218150 Committed r160000: <http://trac.webkit.org/changeset/160000>

WebKit Commit Bot

Comment 4 2013-12-03 04:41:42 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.