Summary: | Web Inspector: Use ESLint to check Inspector JS for code style problems | ||
---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> |
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | 7raivis, darin, ddkilzer, inspector-bugzilla-changes, jonowells, rniwa, saam, syoichi, webkit-bug-importer, ysuzuki |
Priority: | P2 | Keywords: | InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | 125059 | ||
Bug Blocks: | 125045 |
Description
Brian Burg
2013-12-01 16:23:51 PST
Before taking on this bug, I'll note that JSHint retains portions of JSLint's unpleasant Crockford license. (http://en.wikipedia.org/wiki/JSLint#License) So, it would be good to know if this 3rd-party library cannot be included in the project repository on those grounds. I am not aware of any other reasonable 3rd-party JS style checkers. Closure Linter is unconfigurable and only enforces Google style. (In reply to comment #1) > Before taking on this bug, I'll note that JSHint retains portions of JSLint's unpleasant Crockford license. (http://en.wikipedia.org/wiki/JSLint#License) So, it would be good to know if this 3rd-party library cannot be included in the project repository on those grounds. > > I am not aware of any other reasonable 3rd-party JS style checkers. Closure Linter is unconfigurable and only enforces Google style. We have jsmin.py with the Crockford license. But we need to get approval internally at Apple to add any third-party project to WebKit. (In reply to comment #2) > (In reply to comment #1) > > Before taking on this bug, I'll note that JSHint retains portions of JSLint's unpleasant Crockford license. (http://en.wikipedia.org/wiki/JSLint#License) So, it would be good to know if this 3rd-party library cannot be included in the project repository on those grounds. > > > > I am not aware of any other reasonable 3rd-party JS style checkers. Closure Linter is unconfigurable and only enforces Google style. > > We have jsmin.py with the Crockford license. But we need to get approval internally at Apple to add any third-party project to WebKit. Ok, good to know, please update the bug if/when you get approval. I'll peck at the implementation more when I need a side-project break. Of the steps mentioned, I have a patch for (0), and (4) already landed. I also landed a native readFile() so JSHint can run in "Rhino" mode. Lets exposure http://eslint.org instead, it is nicer than JSHint. Is this hooked up to check-webkit-style yet? No, but there is a basic config in the tree now. http://trac.webkit.org/browser/trunk/Source/WebInspectorUI/.eslintrc |