Bug 125017

Summary: Move API files shared between Mac and iOS to the Cocoa directory
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eflews.bot, gyuyoung.kim, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+, eflews.bot: commit-queue-

Description Sam Weinig 2013-11-29 11:03:36 PST 
Move API files shared between Mac and iOS to the Cocoa directory
Comment 1 Sam Weinig 2013-11-29 11:04:08 PST 
Created attachment 218074 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-29 11:06:58 PST 
Attachment 218074 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroup.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroupInternal.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroupPrivate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKConnection.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKConnection.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKConnectionInternal.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroup.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroup.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroupInternal.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroupPrivate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKTypeRefWrapper.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKTypeRefWrapper.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKView.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WebKit2.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupPrivate.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h', u'Source/WebKit2/UIProcess/API/mac/WKConnection.h', u'Source/WebKit2/UIProcess/API/mac/WKConnection.mm', u'Source/WebKit2/UIProcess/API/mac/WKConnectionInternal.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroupPrivate.h', u'Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.h', u'Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.mm', u'Source/WebKit2/UIProcess/API/mac/WKView.h', u'Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h', u'Source/WebKit2/UIProcess/API/mac/WebKit2.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h:87:  Missing spaces around /  [whitespace/operators] [3]
Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:79:  Missing spaces around =  [whitespace/operators] [4]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:32:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:33:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:34:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:35:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:36:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:37:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:38:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:40:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 10 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EFL EWS Bot 2013-11-29 11:11:27 PST 
Comment on attachment 218074 [details]
Patch

Attachment 218074 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/39328181
Comment 4 Build Bot 2013-11-29 11:34:14 PST 
Comment on attachment 218074 [details]
Patch

Attachment 218074 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/39978021
Comment 5 Build Bot 2013-11-29 12:00:30 PST 
Comment on attachment 218074 [details]
Patch

Attachment 218074 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/39998015
Comment 6 Sam Weinig 2013-11-29 12:09:36 PST 
Created attachment 218076 [details]
Patch
Comment 7 WebKit Commit Bot 2013-11-29 12:10:53 PST 
Attachment 218076 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroup.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroupInternal.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroupPrivate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKConnection.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKConnection.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKConnectionInternal.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroup.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroup.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroupInternal.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroupPrivate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKTypeRefWrapper.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKTypeRefWrapper.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKView.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h', u'Source/WebKit2/UIProcess/API/Cocoa/WebKit2.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupPrivate.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h', u'Source/WebKit2/UIProcess/API/mac/WKConnection.h', u'Source/WebKit2/UIProcess/API/mac/WKConnection.mm', u'Source/WebKit2/UIProcess/API/mac/WKConnectionInternal.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroupPrivate.h', u'Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.h', u'Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.mm', u'Source/WebKit2/UIProcess/API/mac/WKView.h', u'Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h', u'Source/WebKit2/UIProcess/API/mac/WebKit2.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h:87:  Missing spaces around /  [whitespace/operators] [3]
Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:79:  Missing spaces around =  [whitespace/operators] [4]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:32:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:33:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:34:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:35:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:36:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:37:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:38:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:40:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 10 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 EFL EWS Bot 2013-11-29 12:14:18 PST 
Comment on attachment 218076 [details]
Patch

Attachment 218076 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/39948028
Comment 9 mitz 2013-11-29 12:47:32 PST 
Comment on attachment 218076 [details]
Patch

rs=me
Comment 10 Sam Weinig 2013-11-29 12:52:04 PST 
Committed r159874: <http://trac.webkit.org/changeset/159874>