Summary: | [WK2] [EFL] Add spatial navigation API in EFL port. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dariusz Frankiewicz <d.frankiewic> | ||||||||||||
Component: | WebKit EFL | Assignee: | Dariusz Frankiewicz <d.frankiewic> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, g.czajkowski, gyuyoung.kim, lucas.de.marchi, rakuco | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Dariusz Frankiewicz
2013-11-29 00:27:59 PST
Created attachment 218049 [details]
patch
Seems fine as this API wraps WK2 spatial navigation settings. Comment on attachment 218049 [details] patch Just two small style issues: View in context: https://bugs.webkit.org/attachment.cgi?id=218049&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:321 > +Eina_Bool ewk_settings_spatial_navigation_enabled_set(Ewk_Settings *settings, Eina_Bool enable) Asterisk should be next to type here... > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:466 > +EAPI Eina_Bool ewk_settings_spatial_navigation_enabled_get(const Ewk_Settings* settings); ...and next to parameter here. Created attachment 218171 [details]
patch v2
Comment on attachment 218171 [details] patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=218171&action=review > Source/WebKit2/ChangeLog:7 > + I prefer to add description. > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:336 > + Unneeded line ? Created attachment 218273 [details]
final patch
Created attachment 218274 [details]
Final patch
Add missing dot in description.
Comment on attachment 218274 [details] Final patch Rejecting attachment 218274 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 218274, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ed 4 diffs from patch file(s). patching file Source/WebKit2/ChangeLog patch: **** malformed patch at line 23: + (TEST_F): patching file Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp patch: **** malformed patch at line 23: patching file Source/WebKit2/UIProcess/API/efl/ewk_settings.h patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/42448041 Created attachment 218275 [details]
rebased patch
Comment on attachment 218275 [details] rebased patch Clearing flags on attachment: 218275 Committed r159996: <http://trac.webkit.org/changeset/159996> |