Bug 125002

Summary:

[WK2] [EFL] Add spatial navigation API in EFL port.

Product:

WebKit

Reporter:

Dariusz Frankiewicz <d.frankiewic>

Component:

WebKit EFL

Assignee:

Dariusz Frankiewicz <d.frankiewic>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, g.czajkowski, gyuyoung.kim, lucas.de.marchi, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
patch v2	gyuyoung.kim: review+
final patch	none
Final patch	commit-queue: commit-queue-
rebased patch	none

Dariusz Frankiewicz

Reported 2013-11-29 00:27:59 PST

Add spatial navigation setting API support to EFL port.

Attachments
patch (3.88 KB, patch) 2013-11-29 02:53 PST, Dariusz Frankiewicz	no flags	Details Formatted Diff Diff
patch v2 (3.88 KB, patch) 2013-12-02 06:53 PST, Dariusz Frankiewicz	gyuyoung.kim: review+	Details Formatted Diff Diff
final patch (4.08 KB, patch) 2013-12-03 00:13 PST, Dariusz Frankiewicz	no flags	Details Formatted Diff Diff
Final patch (4.08 KB, patch) 2013-12-03 00:24 PST, Dariusz Frankiewicz	commit-queue: commit-queue-	Details Formatted Diff Diff
rebased patch (4.03 KB, patch) 2013-12-03 01:12 PST, Dariusz Frankiewicz	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Dariusz Frankiewicz

Comment 1 2013-11-29 02:53:50 PST

Created attachment 218049 [details] patch

Grzegorz Czajkowski

Comment 2 2013-11-29 03:06:42 PST

Seems fine as this API wraps WK2 spatial navigation settings.

Michal Pakula vel Rutka

Comment 3 2013-11-29 06:25:53 PST

Comment on attachment 218049 [details] patch Just two small style issues: View in context: https://bugs.webkit.org/attachment.cgi?id=218049&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:321 > +Eina_Bool ewk_settings_spatial_navigation_enabled_set(Ewk_Settings *settings, Eina_Bool enable) Asterisk should be next to type here... > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:466 > +EAPI Eina_Bool ewk_settings_spatial_navigation_enabled_get(const Ewk_Settings* settings); ...and next to parameter here.

Dariusz Frankiewicz

Comment 4 2013-12-02 06:53:44 PST

Created attachment 218171 [details] patch v2

Gyuyoung Kim

Comment 5 2013-12-02 18:17:36 PST

Comment on attachment 218171 [details] patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=218171&action=review > Source/WebKit2/ChangeLog:7 > + I prefer to add description. > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:336 > + Unneeded line ?

Dariusz Frankiewicz

Comment 6 2013-12-03 00:13:27 PST

Created attachment 218273 [details] final patch

Dariusz Frankiewicz

Comment 7 2013-12-03 00:24:44 PST

Created attachment 218274 [details] Final patch Add missing dot in description.

WebKit Commit Bot

Comment 8 2013-12-03 00:34:17 PST

Comment on attachment 218274 [details] Final patch Rejecting attachment 218274 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 218274, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ed 4 diffs from patch file(s). patching file Source/WebKit2/ChangeLog patch: **** malformed patch at line 23: + (TEST_F): patching file Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp patch: **** malformed patch at line 23: patching file Source/WebKit2/UIProcess/API/efl/ewk_settings.h patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/42448041

Dariusz Frankiewicz

Comment 9 2013-12-03 01:12:42 PST

Created attachment 218275 [details] rebased patch

WebKit Commit Bot

Comment 10 2013-12-03 02:27:00 PST

Comment on attachment 218275 [details] rebased patch Clearing flags on attachment: 218275 Committed r159996: <http://trac.webkit.org/changeset/159996>

Note You need to log in before you can comment on or make changes to this bug.