Bug 124993

Summary:

[EFL] PageViewportController does not need to be unique_ptr instance

Product:

WebKit

Reporter:

Ryuan Choi <ryuan.choi>

Component:

WebKit EFL

Assignee:

Ryuan Choi <ryuan.choi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Ryuan Choi 2013-11-28 17:59:22 PST

PageViewportController and PageViewportControllerEfl have same life cycle with EwkView.
So, we don't need to make them as unique_ptr instance.

Comment 1 Ryuan Choi 2013-11-28 18:53:49 PST

Created attachment 218030 [details]
Patch

Comment 2 Ryuan Choi 2013-11-28 19:26:48 PST

Created attachment 218031 [details]
Patch

Comment 3 Gyuyoung Kim 2013-11-28 19:34:13 PST

Comment on attachment 218031 [details]
Patch

Looks fine.

Comment 4 Ryuan Choi 2013-11-28 19:39:29 PST

Comment on attachment 218031 [details]
Patch

Clearing flags on attachment: 218031

Committed r159863: <http://trac.webkit.org/changeset/159863>

Comment 5 Ryuan Choi 2013-11-28 19:39:36 PST

All reviewed patches have been landed.  Closing bug.