Bug 124991

Summary:

[EFL] Build fix after r159859

Product:

WebKit

Reporter:

Jinwoo Song <jinwoo7.song>

Component:

WebKit EFL

Assignee:

Jinwoo Song <jinwoo7.song>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, commit-queue, lucas.de.marchi, luiz, noam, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Jinwoo Song

Reported 2013-11-28 16:05:53 PST

[ 94%] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp: In static member function ‘static WTF::PassRefPtr<WebKit::WebView> WebKit::WebView::create(WebKit::WebContext*, WebKit::WebPageGroup*)’: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp:54:54: error: cannot allocate an object of abstract type ‘WebKit::WebViewEfl’ In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp:27:0: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.h:39:7: note: because the following virtual functions are pure within ‘WebKit::WebViewEfl’: In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h:34:0, from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.h:29, from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp:27: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/PageClient.h:128:18: note: virtual void WebKit::PageClient::didCommitLoadForMainFrame() /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp:55:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/WebViewEfl.cpp.o] Error 1

Attachments
Patch (2.18 KB, patch) 2013-11-28 16:10 PST, Jinwoo Song	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jinwoo Song

Comment 1 2013-11-28 16:10:48 PST

Created attachment 218026 [details] Patch

WebKit Commit Bot

Comment 2 2013-11-28 16:59:45 PST

Comment on attachment 218026 [details] Patch Clearing flags on attachment: 218026 Committed r159861: <http://trac.webkit.org/changeset/159861>

WebKit Commit Bot

Comment 3 2013-11-28 16:59:47 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.