Bug 124990

Summary:

Rename StylePropertySet to StyleProperties

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eflews.bot, gyuyoung.kim

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+, eflews.bot: commit-queue-

Antti Koivisto

Reported 2013-11-28 12:00:20 PST

Less clunky name

Attachments
patch (379.83 KB, patch) 2013-11-28 12:04 PST, Antti Koivisto	kling: review+ eflews.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2013-11-28 12:04:35 PST

Created attachment 218022 [details] patch

WebKit Commit Bot

Comment 2 2013-11-28 12:05:36 PST

Attachment 218022 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp', u'Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm', u'Source/WebCore/css/CSSAllInOne.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.h', u'Source/WebCore/css/CSSFontFaceRule.cpp', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSPageRule.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSStyleDeclaration.h', u'Source/WebCore/css/CSSStyleRule.cpp', u'Source/WebCore/css/DOMWindowCSS.cpp', u'Source/WebCore/css/ElementRuleCollector.cpp', u'Source/WebCore/css/ElementRuleCollector.h', u'Source/WebCore/css/FontLoader.cpp', u'Source/WebCore/css/PageRuleCollector.cpp', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.h', u'Source/WebCore/css/StyleProperties.cpp', u'Source/WebCore/css/StyleProperties.h', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StylePropertySet.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/css/StyleRule.cpp', u'Source/WebCore/css/StyleRule.h', u'Source/WebCore/css/StyleSheetContents.cpp', u'Source/WebCore/css/ViewportStyleResolver.cpp', u'Source/WebCore/css/ViewportStyleResolver.h', u'Source/WebCore/css/WebKitCSSFilterRule.cpp', u'Source/WebCore/css/WebKitCSSKeyframeRule.cpp', u'Source/WebCore/css/WebKitCSSKeyframeRule.h', u'Source/WebCore/css/WebKitCSSKeyframesRule.cpp', u'Source/WebCore/css/WebKitCSSMatrix.cpp', u'Source/WebCore/css/WebKitCSSViewportRule.cpp', u'Source/WebCore/dom/Attr.cpp', u'Source/WebCore/dom/Attr.h', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/ElementData.cpp', u'Source/WebCore/dom/ElementData.h', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/dom/StyledElement.h', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/EditingStyle.h', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/Editor.h', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/FrameSelection.h', u'Source/WebCore/editing/RemoveCSSPropertyCommand.cpp', u'Source/WebCore/editing/RemoveFormatCommand.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/ios/EditorIOS.mm', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/html/HTMLBRElement.cpp', u'Source/WebCore/html/HTMLBRElement.h', u'Source/WebCore/html/HTMLBodyElement.cpp', u'Source/WebCore/html/HTMLBodyElement.h', u'Source/WebCore/html/HTMLDivElement.cpp', u'Source/WebCore/html/HTMLDivElement.h', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLElement.h', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.h', u'Source/WebCore/html/HTMLFontElement.cpp', u'Source/WebCore/html/HTMLFontElement.h', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.h', u'Source/WebCore/html/HTMLHRElement.cpp', u'Source/WebCore/html/HTMLHRElement.h', u'Source/WebCore/html/HTMLIFrameElement.cpp', u'Source/WebCore/html/HTMLIFrameElement.h', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLImageElement.h', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLInputElement.h', u'Source/WebCore/html/HTMLLIElement.cpp', u'Source/WebCore/html/HTMLLIElement.h', u'Source/WebCore/html/HTMLMarqueeElement.cpp', u'Source/WebCore/html/HTMLMarqueeElement.h', u'Source/WebCore/html/HTMLOListElement.cpp', u'Source/WebCore/html/HTMLOListElement.h', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLObjectElement.h', u'Source/WebCore/html/HTMLParagraphElement.cpp', u'Source/WebCore/html/HTMLParagraphElement.h', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.h', u'Source/WebCore/html/HTMLPreElement.cpp', u'Source/WebCore/html/HTMLPreElement.h', u'Source/WebCore/html/HTMLTableCaptionElement.cpp', u'Source/WebCore/html/HTMLTableCaptionElement.h', u'Source/WebCore/html/HTMLTableCellElement.cpp', u'Source/WebCore/html/HTMLTableCellElement.h', u'Source/WebCore/html/HTMLTableColElement.cpp', u'Source/WebCore/html/HTMLTableColElement.h', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTableElement.h', u'Source/WebCore/html/HTMLTablePartElement.cpp', u'Source/WebCore/html/HTMLTablePartElement.h', u'Source/WebCore/html/HTMLTableSectionElement.cpp', u'Source/WebCore/html/HTMLTableSectionElement.h', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.h', u'Source/WebCore/html/HTMLUListElement.cpp', u'Source/WebCore/html/HTMLUListElement.h', u'Source/WebCore/html/HTMLVideoElement.cpp', u'Source/WebCore/html/HTMLVideoElement.h', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/CanvasStyle.cpp', u'Source/WebCore/html/shadow/MediaControlElementTypes.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/loader/EmptyClients.h', u'Source/WebCore/mathml/MathMLElement.cpp', u'Source/WebCore/mathml/MathMLElement.h', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EditorClient.h', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/page/PageSerializer.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/svg/SVGAnimateElement.cpp', u'Source/WebCore/svg/SVGElement.cpp', u'Source/WebCore/svg/SVGElement.h', u'Source/WebCore/svg/SVGElementRareData.h', u'Source/WebCore/svg/SVGFontFaceElement.cpp', u'Source/WebCore/svg/SVGImageElement.cpp', u'Source/WebCore/svg/SVGImageElement.h', u'Source/WebCore/svg/SVGTextContentElement.cpp', u'Source/WebCore/svg/SVGTextContentElement.h', u'Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h', u'Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit/win/WebCoreSupport/WebEditorClient.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h']" exit_code: 1 Source/WebCore/css/StyleProperties.cpp:211: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/StyleProperties.cpp:373: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/css/StyleProperties.cpp:393: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 159 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 3 2013-11-28 12:08:56 PST

Comment on attachment 218022 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=218022&action=review PropertySetCSSStyleDeclaration could use a new name, too. > Source/WebCore/ChangeLog:6 > + "Set" does not add useful informatio here. Use less clunky plural name. information

EFL EWS Bot

Comment 4 2013-11-28 12:36:25 PST

Comment on attachment 218022 [details] patch Attachment 218022 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/39138006

Antti Koivisto

Comment 5 2013-11-28 12:51:54 PST

https://trac.webkit.org/r159856

Note You need to log in before you can comment on or make changes to this bug.