Bug 124969

Summary:

Add default port feature to Tools/Scripts/set-webkit-configuration

Product:

WebKit

Reporter:

Éva Balázsfalvi <evab.u-szeged>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

commit-queue, dbates, evab.u-szeged, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	bfulgham: review-

Description Éva Balázsfalvi 2013-11-28 06:28:02 PST

Add default platform feature to Tools/Scripts/set-webkit-configuration
(--efl, --gtk, ... ) and related scripts to be able skip passing the
platform option always to build-webkit, run-webkit-tests, run-perf-tests, ...

Comment 1 Éva Balázsfalvi 2013-11-28 06:33:17 PST

Created attachment 217998 [details]
Patch

Comment 2 Éva Balázsfalvi 2014-02-11 07:55:29 PST

Created attachment 223863 [details]
Patch

Comment 3 Éva Balázsfalvi 2014-02-17 02:07:06 PST

Ping?

Comment 4 Zoltan Horvath 2014-02-27 15:21:52 PST

Comment on attachment 223863 [details]
Patch

This set-webkit-configuration file is pretty outdated. Does anyone use this anymore? Is it even possible to make a 32-bit builds? 
Anyways, I propose to rather remove this script...

Comment 5 Csaba Osztrogonác 2014-02-28 03:38:31 PST

(In reply to comment #4)
> (From update of attachment 223863 [details])
> This set-webkit-configuration file is pretty outdated. 
> Does anyone use this anymore? 
Why do you think? It works fine to set debug/release/32-bit build as default.

> Is it even possible to make a 32-bit builds? 
Yes, but this feture works only on Apple Mac. On 64 bit Linux 
isn't so trivial to do same thing. It is much more easier to 
build on a 32 bit machine or inside a 32 bit chroot.

> Anyways, I propose to rather remove this script...
I don't agree with you at all. It is a big help if you don't have to 
pass --efl/--gtk to all scripts when you always work on the same port.
Would you like if --mac would be mandatory for you? :) I think no.

Comment 6 Brent Fulgham 2016-03-14 11:11:11 PDT

Comment on attachment 223863 [details]
Patch

This patch is fairly out of date. Can someone in the GTK/EFL ports rebaseline and complete the review process? I'm marking it r- since the patch is out of date, not because I disagree with the change.