Bug 124954 – REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false

• Component: WebKit API
• Status: RESOLVED FIXED

[David]

this is webkit 2.2.1.  The following code correctly toggled viewing the source with previous webkit versions.

int
toggle() {
gboolean mode;

mode = webkit_web_view_get_view_source_mode(t->wv);
mode = !mode;
webkit_web_view_set_view_source_mode(t->wv, mode);
return (0);
}

However, the first call correctly views the source code, but the next call does not toggle back due to mode = webkit_web_view_get_view_source_mode(t->wv); always returning FALSE.

webkit is compiled with --disable-webkit2.

[Gustavo Noronha (kov)]

Heh:

@@ -5181,8 +5166,7 @@ gboolean webkit_web_view_get_view_source_mode (WebKitWebView* webView)
 {
     g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), FALSE);
 
-    if (Frame* mainFrame = core(webView)->mainFrame())
-        return mainFrame->inViewSourceMode();
+    core(webView)->mainFrame().inViewSourceMode();
 
     return FALSE;
 }

From 095b544b7.

[Gustavo Noronha (kov)]

Created attachment 217995 [details]
Patch

[Gustavo Noronha (kov)]

Committed r159843: <http://trac.webkit.org/changeset/159843>