Bug 124938

Summary: [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
Product: WebKit Reporter: Andres Gomez Garcia <agomez>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gordon.lou, gustavo, mario, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124940    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Andres Gomez Garcia 2013-11-27 06:58:38 PST
Debootsrapped Debian Testing in which we have installed the needed dependencies with:

$ Tools/gtk/install-dependencies

Then, we try to updated the jhbuild dependencies and we get:

$ Tools/Scripts/update-webkitgtk-libs
Updating GTK+ port dependencies using jhbuild...
Traceback (most recent call last):
  File "./jhbuild-wrapper", line 120, in <module>
    ensure_jhbuild(platform)
  File "./jhbuild-wrapper", line 103, in ensure_jhbuild
    clone_jhbuild()
  File "./jhbuild-wrapper", line 71, in clone_jhbuild
    process = subprocess.Popen(['git', 'clone', 'git://git.gnome.org/jhbuild'], cwd=source_path)
  File "/usr/lib/python2.7/subprocess.py", line 709, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1326, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
Running jhbuild-wrapper build failed.
Died at Tools/Scripts/update-webkitgtk-libs line 24.
Comment 1 Andres Gomez Garcia 2013-11-27 07:15:43 PST
Created attachment 217948 [details]
Patch
Comment 2 Andres Gomez Garcia 2013-11-27 07:21:25 PST
Created attachment 217949 [details]
Patch
Comment 3 Martin Robinson 2013-11-27 07:57:58 PST
Comment on attachment 217948 [details]
Patch

So the problems was that the dependencies were not sorted?
Comment 4 Philippe Normand 2013-11-27 08:15:37 PST
Can you merge the patches? We handle one patch/commit per bug.
Comment 5 Andres Gomez Garcia 2013-11-27 08:28:54 PST
(In reply to comment #3)
> (From update of attachment 217948 [details])
> So the problems was that the dependencies were not sorted?

No, the problem is that "git" dependency is missing. I just decided to split in 2 so the actual purpose of the patch won't be "lost" in the sorting.
Comment 6 Andres Gomez Garcia 2013-11-27 08:34:18 PST
Created attachment 217954 [details]
Patch
Comment 7 Andres Gomez Garcia 2013-11-27 08:34:50 PST
(In reply to comment #4)
> Can you merge the patches? We handle one patch/commit per bug.

Done.
Comment 8 WebKit Commit Bot 2013-11-27 09:22:12 PST
Comment on attachment 217954 [details]
Patch

Clearing flags on attachment: 217954

Committed r159818: <http://trac.webkit.org/changeset/159818>
Comment 9 WebKit Commit Bot 2013-11-27 09:22:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 gordon 2015-12-18 04:51:35 PST
You should not run jhbuild as root.
Failed to build GTK+ port dependencies with jhbuild
Died at Tools/Scripts/update-webkitgtk-libs line 24.