Bug 124918

Summary: Style checker requires alphabetical ordering in cmake lists even it contains variable.
Product: WebKit Reporter: Gergő Balogh <gbalogh.u-szeged>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch none

Gergő Balogh
Reported 2013-11-27 02:00:13 PST
For example: ${foo} ${bar} is bad ${bar} ${foo} is ok
Attachments
patch (1.56 KB, patch)
2013-11-27 02:11 PST, Gergő Balogh
no flags
patch (1.13 KB, patch)
2013-11-27 23:49 PST, Gergő Balogh
no flags
patch (1.81 KB, patch)
2013-12-04 04:15 PST, Gergő Balogh
no flags
patch (1.81 KB, patch)
2013-12-04 04:23 PST, Gergő Balogh
no flags
Gergő Balogh
Comment 1 2013-11-27 02:11:31 PST
Gergő Balogh
Comment 2 2013-11-27 23:49:40 PST
Csaba Osztrogonác
Comment 3 2013-12-03 04:17:34 PST
Comment on attachment 217984 [details] patch This patch looks good to me, but could you add a unittest for this change?
Gergő Balogh
Comment 4 2013-12-04 04:15:51 PST
Created attachment 218398 [details] patch unittest updated
Gergő Balogh
Comment 5 2013-12-04 04:23:56 PST
Csaba Osztrogonác
Comment 6 2013-12-04 05:19:24 PST
Comment on attachment 218399 [details] patch r=me
WebKit Commit Bot
Comment 7 2013-12-04 05:46:48 PST
Comment on attachment 218399 [details] patch Clearing flags on attachment: 218399 Committed r160090: <http://trac.webkit.org/changeset/160090>
WebKit Commit Bot
Comment 8 2013-12-04 05:46:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.