Bug 124878

Summary: Avoid unnecessary copy-on-write in FillLayer style application.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, koivisto, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch idea none

Andreas Kling
Reported 2013-11-25 18:18:17 PST
ApplyPropertyFillLayer always creates a mutable copy of the StyleBackgroundData. Because stupid.
Attachments
Patch idea (2.65 KB, patch)
2013-11-25 18:18 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-11-25 18:18:50 PST
Created attachment 217855 [details] Patch idea
Antti Koivisto
Comment 2 2013-11-26 07:50:01 PST
Comment on attachment 217855 [details] Patch idea View in context: https://bugs.webkit.org/attachment.cgi?id=217855&action=review > Source/WebCore/css/DeprecatedStyleBuilder.cpp:519 > + if (*(styleResolver->parentStyle()->*layersFunction)() == *(styleResolver->style()->*layersFunction)()) kinda wat
WebKit Commit Bot
Comment 3 2013-11-26 08:17:40 PST
Comment on attachment 217855 [details] Patch idea Clearing flags on attachment: 217855 Committed r159782: <http://trac.webkit.org/changeset/159782>
WebKit Commit Bot
Comment 4 2013-11-26 08:17:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.