Summary: | Web Inspector: Crash when starting the Inspector | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexandru Chiculita <achicu> | ||||
Component: | Web Inspector | Assignee: | Alexandru Chiculita <achicu> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | andersca, bburg, graouts, joepeck, sam, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Alexandru Chiculita
2013-11-25 15:05:32 PST
The issue is simple, but I don't know how it didn't reproduce so far: WebInspector::createInspectorPage() sends Messages::WebInspectorProxy::CreateInspectorPage and waits in sync mode. WebInspectorProxy::CreateInspectorPage will send back two messages + the sync reply: 1. Messages::WebProcess::CreateWebPageGroup. 2. Messages::WebProcess::CreateWebPage. WebInspector::createInspectorPage wakes up when it receives the reply, but the two messages from the WebInspectorProxy::CreateInspectorPage are still pending to execute. The problem is that WebInspector::createInspectorPage forces the call to WebProcess::shared().createWebPage using the data in the sync reply. That's even though there's a pending message that will creating anyway. The crash happens when the page tries to use the PageGroup that has not been created yet. The page group creation message didn't had a chance to process. It seems like a simple fix would be to replace the following line in WebPageProxy::initializeWebPage() m_process->send(Messages::WebProcess::CreateWebPageGroup(m_pageGroup->pageGroupID(), m_pageGroup->data()), 0); should be: m_process->send(Messages::WebProcess::CreateWebPageGroup(m_pageGroup->pageGroupID(), m_pageGroup->data()), 0, CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply); Created attachment 217842 [details]
Patch V1
The patch that introduced the initial crash was rolled out :) https://bugs.webkit.org/show_bug.cgi?id=124859 Comment on attachment 217842 [details] Patch V1 Cleared review? from attachment 217842 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). |