Summary: | [EFL] Ensure EGLOffScreenContext::initialize calls platformMakeCurrent on the surface | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Pena <spenap> | ||||||||
Component: | WebKit EFL | Assignee: | Simon Pena <spenap> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bunhere, cmarcelo, commit-queue, gyuyoung.kim, hw1008.kim, kenneth, kkristof, lucas.de.marchi, luiz, noam, ossy, sergio, szledan, zeno, zherczeg | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Simon Pena
2013-11-25 01:47:05 PST
Created attachment 217778 [details]
Patch
This bug also affects NIX port. Ryuan and Hyowon, does EFL port need to use this patch ? I think we need to call eglDestroyContext if platformMakeCurrent is failed on the line 104. (In reply to comment #4) > I think we need to call eglDestroyContext if platformMakeCurrent is failed on the line 104. Ah, like we do on line 96? I will update the patch, thanks. Created attachment 231762 [details]
Patch
Comment on attachment 231762 [details]
Patch
You could say what problem this patch fixes, maybe?
Created attachment 231768 [details]
Patch
(In reply to comment #7) > (From update of attachment 231762 [details]) > You could say what problem this patch fixes, maybe? Hopefully this version is a bit more clear in the changelog =) Comment on attachment 231768 [details]
Patch
r=me
(In reply to comment #10) > (From update of attachment 231768 [details]) > r=me Thanks for the review! I will land it tomorrow. Comment on attachment 231768 [details] Patch Clearing flags on attachment: 231768 Committed r169153: <http://trac.webkit.org/changeset/169153> All reviewed patches have been landed. Closing bug. |