Bug 124832

Summary: [EFL] Ensure EGLOffScreenContext::initialize calls platformMakeCurrent on the surface
Product: WebKit Reporter: Simon Pena <spena>
Component: WebKit EFLAssignee: Simon Pena <spena>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cmarcelo, commit-queue, gyuyoung.kim, hw1008.kim, kenneth, kkristof, lucas.de.marchi, luiz, noam, ossy, sergio, szledan, zeno, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Simon Pena
Reported 2013-11-25 01:47:05 PST
Currently EGLOffScreenContext::initialize only calls platformMakeCurrent when the GL_EXT_robustness extension is available. platformMakeCurrent should be call regardless of the availability of the extension. Patch following now.
Attachments
Patch (1.90 KB, patch)
2013-11-25 01:52 PST, Simon Pena 		no flags
DetailsFormatted DiffDiff
Patch (1.97 KB, patch)
2014-05-20 05:46 PDT, Simon Pena 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2014-05-20 08:05 PDT, Simon Pena 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Pena
Comment 1 2013-11-25 01:52:55 PST
Created attachment 217778 [details] Patch
Simon Pena
Comment 2 2013-12-18 03:08:19 PST
This bug also affects NIX port.
Gyuyoung Kim
Comment 3 2014-05-07 02:56:30 PDT
Ryuan and Hyowon, does EFL port need to use this patch ?
Hyowon Kim
Comment 4 2014-05-20 00:17:29 PDT
I think we need to call eglDestroyContext if platformMakeCurrent is failed on the line 104.
Simon Pena
Comment 5 2014-05-20 01:23:04 PDT
(In reply to comment #4) > I think we need to call eglDestroyContext if platformMakeCurrent is failed on the line 104. Ah, like we do on line 96? I will update the patch, thanks.
Simon Pena
Comment 6 2014-05-20 05:46:08 PDT
Created attachment 231762 [details] Patch
Antonio Gomes
Comment 7 2014-05-20 06:24:27 PDT
Comment on attachment 231762 [details] Patch You could say what problem this patch fixes, maybe?
Simon Pena
Comment 8 2014-05-20 08:05:17 PDT
Created attachment 231768 [details] Patch
Simon Pena
Comment 9 2014-05-20 08:10:26 PDT
(In reply to comment #7) > (From update of attachment 231762 [details]) > You could say what problem this patch fixes, maybe? Hopefully this version is a bit more clear in the changelog =)
Antonio Gomes
Comment 10 2014-05-20 08:37:41 PDT
Comment on attachment 231768 [details] Patch r=me
Simon Pena
Comment 11 2014-05-20 09:11:13 PDT
(In reply to comment #10) > (From update of attachment 231768 [details]) > r=me Thanks for the review! I will land it tomorrow.
WebKit Commit Bot
Comment 12 2014-05-21 02:11:47 PDT
Comment on attachment 231768 [details] Patch Clearing flags on attachment: 231768 Committed r169153: <http://trac.webkit.org/changeset/169153>
WebKit Commit Bot
Comment 13 2014-05-21 02:11:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.