Bug 124823

Summary: Buggy on building jsc only for gtk port from cmake system.
Product: WebKit Reporter: yangqi3 <yangqi3>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: commit-queue, gyuyoung.kim, mrobinson, ossy, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patches to expose some macros to upper level cmake files and command line none

yangqi3
Reported 2013-11-24 19:47:52 PST
The current cmake file system for gtk is not able to expose the options to build JSC only. The OptionsGtk.cmake get fixed options (which ignore the global macro defines from upper level or from cmake -DXXX=XXX. I am trying to provide this patch to expose this macros to follow the upper most level of defines (from commander line)
Attachments
Patches to expose some macros to upper level cmake files and command line (1.27 KB, patch)
2013-11-24 19:49 PST, yangqi3 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yangqi3
Comment 1 2013-11-24 19:49:30 PST
Created attachment 217770 [details] Patches to expose some macros to upper level cmake files and command line Please review this patch, and decide if we have to make some changes to the cmake system.
Martin Robinson
Comment 2 2013-12-18 05:18:29 PST
Perhaps it makes more sense to handle this during build-time instead of configure time? Why not just run "make JavaScriptCore"
Martin Robinson
Comment 3 2013-12-23 06:44:20 PST
Not sure this is a blocker for the CMake build so removing the dependency.
Note You need to log in before you can comment on or make changes to this bug.