| Summary: | check-webkit-style should check for extraneous newline between config.h and primary header | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin, glenn, llango.u-szeged, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| URL: | http://www.webkit.org/coding/coding-style.html#include-config-h | ||||||||
| Attachments: |
|
||||||||
|
Description
Brian Burg
2013-11-24 18:04:48 PST
(In reply to comment #0) > The solution should be added in the vicinity of Source/Tools/Scripts/webkitpy/style/checkers/cpp.py, in function check_include_line. Why do you want an extra blank line between the config.h and primary header? On the given URL there is no such rule. extraneous, meaning that it is not necessary. So the following is good: #include "config.h" #include "Foo.h" the following is discouraged: #include "config.h" #include "Foo.h" Created attachment 218038 [details]
patch
Comment on attachment 218038 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=218038&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:2821 > # Check to make sure we have a blank line after primary header. Please fix this comment before landing. Created attachment 218055 [details]
patch fix
Comment on attachment 218055 [details] patch fix Clearing flags on attachment: 218055 Committed r159872: <http://trac.webkit.org/changeset/159872> All reviewed patches have been landed. Closing bug. |