Summary: | Add TextTrackList::getTrackById(). | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brendan Long <b.long> | ||||||
Component: | Media | Assignee: | Brendan Long <b.long> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kondapallykalyan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Brendan Long
2013-11-22 11:36:53 PST
It looks like AudioTrackList and VideoTrackList already have it. I think this was added to the spec after those interfaces were created. Created attachment 217708 [details]
Patch
Comment on attachment 217708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217708&action=review > Source/WebCore/html/track/TextTrackList.cpp:143 > + return 0; Nit: nullptr > Source/WebCore/html/track/TextTrackList.h:51 > + TextTrack* getTrackById(const AtomicString& id); Nit: "id" is unnecessary. Created attachment 217711 [details]
Fix nits
Comment on attachment 217711 [details] Fix nits Clearing flags on attachment: 217711 Committed r159711: <http://trac.webkit.org/changeset/159711> All reviewed patches have been landed. Closing bug. |