Bug 124774

Summary:

WebView assumes accelerated compositing

Product:

WebKit

Reporter:

Alex Christensen <alex.christensen>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Trivial

CC:

bdakin, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 8

Attachments:

Description	Flags
Patch	simon.fraser: review+

Alex Christensen

Reported 2013-11-22 07:29:39 PST

Some of our less accelerated friends are failing to compile WebView.cpp because of a lack of USE(ACCELERATED_COMPOSITING) macros. http://build.webkit.org/builders/WinCairo%20Release/builds/33849/steps/compile-webkit/logs/stdio I'm working on using accelerated compositing with TextureMapper, but let's fix this for the WinCairo bot.

Attachments
Patch (2.54 KB, patch) 2013-11-22 08:01 PST, Alex Christensen	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-11-22 08:01:21 PST

Created attachment 217685 [details] Patch

Alex Christensen

Comment 2 2013-11-22 08:07:25 PST

I'm not sure why the patch doesn't apply, but I'm sure someone won't like the style and redundant code, so I'll wait for their comment and upload a new patch.

Alex Christensen

Comment 3 2013-11-22 11:03:35 PST

This was fixed by peavo in r159688. He did a cleaner fix, too. That's why the patches didn't apply. *** This bug has been marked as a duplicate of bug 124773 ***

Note You need to log in before you can comment on or make changes to this bug.